ychernysh commented on code in PR #2937:
URL: https://github.com/apache/drill/pull/2937#discussion_r1741151607
##########
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java:
##########
@@ -751,6 +752,17 @@ public static MinorType
getLeastRestrictiveType(MinorType... types) {
return result;
}
+ public static MajorType getLeastRestrictiveMajorType(MajorType...
majorTypes) {
Review Comment:
The added method is, essentially, just a convenient combination of
[getLeastRestrictiveType](https://github.com/apache/drill/blob/drill-1.21.2/exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java#L723-L752)
(for minor types) and
[getLeastRestrictiveDataMode](https://github.com/apache/drill/blob/drill-1.21.2/exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java#L704-L721)
(for data modes). The examples you put seem to be related only to the former
one, which I didn't aim to change, aren't they? So how about handling it in a
separate task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
