ychernysh commented on code in PR #2937: URL: https://github.com/apache/drill/pull/2937#discussion_r1741161028
########## exec/java-exec/src/test/java/org/apache/drill/TestParquetMissingColumns.java: ########## @@ -0,0 +1,91 @@ +package org.apache.drill; + +import org.apache.drill.common.types.TypeProtos; +import org.apache.drill.common.types.Types; +import org.apache.drill.exec.record.BatchSchema; +import org.apache.drill.exec.record.BatchSchemaBuilder; +import org.apache.drill.exec.record.metadata.SchemaBuilder; +import org.apache.drill.test.ClusterFixture; +import org.apache.drill.test.ClusterTest; +import org.junit.BeforeClass; +import org.junit.Test; + +/** + * Covers selecting completely missing columns from a parquet table. Should create Nullable Int + * ValueVector in that case since there is no chance to guess the correct data type here. + */ Review Comment: `NULLABLE INT` is just what was there when I came to this issue. I think it would be easy to make it configurable by user (if there is any function able to parse type from string). Should we add it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
