cgivre commented on PR #2997: URL: https://github.com/apache/drill/pull/2997#issuecomment-3028026636
@shfshihuafeng Regarding the unit tests, they really don't have to be complicated. You can use the example below as a template, but basically, we just want to make sure that the correct limit is being pushed into the query plan. I'd include a query with a limit set and another with an `OFFSET`. Same goes for the filter pushdown. It shouldn't be much work. https://github.com/apache/drill/blob/b4dd73875ee3e6932f91fdee56e6692a48a06cb4/contrib/format-httpd/src/test/java/org/apache/drill/exec/store/httpd/TestHTTPDLogReader.java#L141-150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
