shfshihuafeng commented on PR #2997: URL: https://github.com/apache/drill/pull/2997#issuecomment-3028463550
> > @shfshihuafeng Regarding the unit tests, they really don't have to be complicated. You can use the example below as a template, but basically, we just want to make sure that the correct limit is being pushed into the query plan. I'd include a query with a limit set and another with an `OFFSET`. Same goes for the filter pushdown. It shouldn't be much work. > > https://github.com/apache/drill/blob/b4dd73875ee3e6932f91fdee56e6692a48a06cb4/contrib/format-httpd/src/test/java/org/apache/drill/exec/store/httpd/TestHTTPDLogReader.java#L141-#L150 > > @cgivre Thank you for your case . I have finished unit tests for this pr, but When I run this unit tests with jdk17, I found that it couldn't be executed When I use a JDK greater than 1.8(such as JDK17), if the test cases inherit HiveTestBase, those test cases couldn't be executed, like the following . this week I have a lot of work to do, so I haven't dealt with this problem yet. I can complete it next week, including unit testing for another PR > > ``` > [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.296 s -- in org.apache.drill.exec.TestHiveProjectPushDown > [INFO] Running org.apache.drill.exec.TestHiveDrillNativeParquetReader > [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.368 s -- in org.apache.drill.exec.TestHiveDrillNativeParquetReader > [INFO] Running org.apache.drill.exec.fn.hive.TestHiveUDFs > [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.200 s -- in org.apache.drill.exec.fn.hive.TestHiveUDFs > ``` ``` /** * Current Hive version doesn't support JDK 9+. * Checks if current version is supported by Hive. * * @return {@code true} if current version is supported by Hive, {@code false} otherwise */ public static boolean supportedJavaVersion() { return System.getProperty("java.version").startsWith("1.8"); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
