jihoonson commented on a change in pull request #5492: Native parallel batch
indexing without shuffle
URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201892300
##########
File path:
indexing-service/src/main/java/io/druid/indexing/overlord/RemoteTaskRunner.java
##########
@@ -465,6 +467,23 @@ public RemoteTaskRunnerConfig getConfig()
return ImmutableList.copyOf(Iterables.concat(pendingTasks.values(),
runningTasks.values(), completeTasks.values()));
}
+ @Nullable
+ @Override
+ public RunnerTaskState getRunnerTaskState(String taskId)
Review comment:
What is the benefit of using Optional instead of returning null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org
