jihoonson commented on a change in pull request #5492: Native parallel batch
indexing without shuffle
URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r203167919
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/io/druid/indexing/kafka/KafkaIndexTaskClient.java
##########
@@ -180,18 +113,17 @@ public boolean resume(final String id)
if (response.getStatus().equals(HttpResponseStatus.OK)) {
log.info("Task [%s] paused successfully", id);
- return jsonMapper.readValue(response.getContent(), new
TypeReference<Map<Integer, Long>>()
+ return deserialize(response.getContent(), new
TypeReference<Map<Integer, Long>>()
Review comment:
I can't agree more. Also, I think we should define a formal way to
communicate between peons <-> peons and peons <-> overlords. The way we're
using for native parallel batch indexing and kafka indexing is somewhat ad-hoc
which is not easy to maintain. This return type can also be defined as a part
of this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
