jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204942207
##########
File path:
processing/src/main/java/io/druid/query/extraction/StrlenExtractionFn.java
##########
@@ -40,6 +41,9 @@ public static StrlenExtractionFn instance()
@Override
public String apply(@Nullable String value)
{
+ if (NullHandling.sqlCompatible() && value == null) {
+ return null;
Review comment:
Please annotate `@Nullable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
