jihoonson commented on a change in pull request #5958: Part 2 of changes for
SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204922799
##########
File path:
processing/src/main/java/io/druid/query/aggregation/DoubleMaxAggregatorFactory.java
##########
@@ -51,25 +53,44 @@ public DoubleMaxAggregatorFactory(String name, String
fieldName)
}
@Override
- public Aggregator factorize(ColumnSelectorFactory metricFactory)
+ protected BaseDoubleColumnValueSelector selector(ColumnSelectorFactory
metricFactory)
{
- return new DoubleMaxAggregator(getDoubleColumnSelector(metricFactory,
Double.NEGATIVE_INFINITY));
+ return getDoubleColumnSelector(
+ metricFactory,
+ Double.NEGATIVE_INFINITY
Review comment:
And do we need to change this to something else which can actually represent
a null? If so, do you have a plan for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
