Thanks for adding details. Based on your answers, I assume it is not being tested. We should add tests as soon as possible. Since you have some experience in this area, can you add some? I'm also not sure why Superset releases the helm chart separately. I would suggest releasing it per our regular release schedule unless there is a good reason for doing so. This will reduce the release burden of the community.
So far, it seems reasonable to me to host the helm chart in the Druid repo. However, as I mentioned before, the migration process might not be proper. I haven't had a chance to look at the IP clearance process closely yet and probably will not have some even in the near future. Benedict, you are a PMC member too. Can you please study the process and give us suggestions on what we should do? Since not many people in the Druid community might not be familiar with this process, you may want to ask questions in the Apache general mailing list. See https://www.mail-archive.com/general@incubator.apache.org/msg74849.html as a reference. We should resolve this issue before the 0.22.0 release. Otherwise, we will have to revert all changes related to the helm chart in the release branch because it doesn't seem necessarily a release blocker for 0.22.0. On Sun, May 2, 2021 at 8:15 PM Benedict Jin <asdf2...@apache.org> wrote: > > Hi Jihoon Son, > > Thank you very much for this list of questions. The following is my personal > understanding. > > 1. What is the current status of the project? > > Helm has undergone a major version upgrade. Helm3 will continue to be > maintained, but Helm2 will no longer be maintained, and the Helm Chart > related to the Apache project is no longer maintained in Helm3. It is > recommended to maintain it in their respective Apache projects. > > 2. Does it reflect the most recent release of Druid? > > Will not affect the release of Druid. Druid's Helm Chart is released > separately. FYI, https://github.com/apache/superset/releases > > 3. How is it being tested? > > It can be verified and tested automatically through Github Action. FYI, > https://github.com/apache/superset/blob/master/.github/workflows/superset-helm-lint.yml > > 4. Why is it best to host the helm chart in the druid repo? > > Because Helm3 no longer maintains the Helm Chart of Apache-related projects, > the official also recommends maintaining it in their respective projects. > Many projects have already done so. The maintenance in the main Druid > warehouse can be seen by more people and help more people quickly build the > Druid environment on K8S. > > Hope these answers can answer some of your doubts. Thanks again. > > Regards, > Benedict Jin > > On 2021/04/27 03:17:29, Julian Hyde <jhyde.apa...@gmail.com> wrote: > > This code was developed outside of the ASF, so it’s possible that we need > > to go through the IP clearance process [1]. Can a PMC member please figure > > out the answer to that question, and answer on this list. > > > > Has the Helm project given any indication whether they approve or > > disapprove of the code being copied into Druid? > > > > Does Druid intend to take ownership of the code? I.e. be the one and only > > copy of this code, do necessary maintenance work (especially including > > security fixes) and accepting patches. > > > > Julian > > > > [1] https://incubator.apache.org/ip-clearance/ > > > > > > > > > On Apr 26, 2021, at 7:33 PM, Benedict Jin <asdf2...@apache.org> wrote: > > > > > > Hi Senlan, > > > > > > Thank you very much for your message and support. I have created a PR to > > > do the migration, referring to the experience of Apache Superset. FYI, > > > https://github.com/apache/druid/pull/11163 and > > > https://github.com/apache/superset/tree/master/helm/superset . > > > > > > Regards, > > > Benedict Jin > > > > > > On 2021/04/26 12:59:12, Senlan Yao <hellis...@gmail.com> wrote: > > >> Thanks @Benedict Jin, > > >> It is a good idea to maintain the Druid Helm's Chart in the Apache > > >> repository. > > >> Since "https://github.com/helm/charts"; repo has been deprecation, we > > >> can't maintain the chart, and the k8s user can't find druid chart > > >> package from > > >> "https://artifacthub.io/packages/search?page=1&ts_query_web=druid"; any > > >> more. > > >> If we can maintain chart in the Apache repository, it will solve > > >> https://github.com/apache/druid/issues/5582, ans also the the k8s user > > >> can install Druid from helm chart package. > > >> > > >> On 2021/04/22 01:58:46, Benedict Jin <asdf2...@apache.org> wrote: > > >>> Hi all, > > >>> > > >>> Should we maintain the Helm's Chart in the Apache Druid repository? Now > > >>> the development and maintenance of Helm's Chart has been stalled. It > > >>> was previously maintained by @maver1ck @AWaterColorPen and me > > >>> (@asdf2014). Currently, > > >>> https://github.com/helm/charts/tree/master/incubator/druid cannot be > > >>> maintained. I recommend that we just copy this directory directly to > > >>> the root directory of https://github.com/apache/druid and maintain it. > > >>> But I'm not so sure whether there is a license issue. What do you think? > > >>> > > >>> Regards, > > >>> Benedict Jin > > >>> > > >>> --------------------------------------------------------------------- > > >>> To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org > > >>> For additional commands, e-mail: dev-h...@druid.apache.org > > >>> > > >>> > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org > > >> For additional commands, e-mail: dev-h...@druid.apache.org > > >> > > >> > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org > > > For additional commands, e-mail: dev-h...@druid.apache.org > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org > > For additional commands, e-mail: dev-h...@druid.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org > For additional commands, e-mail: dev-h...@druid.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org For additional commands, e-mail: dev-h...@druid.apache.org
