Hi, On Sat, Sep 8, 2018 at 9:34 AM Justin Mclean <jus...@classsoftware.com> wrote: > > Hi, > > >>> This product contains code derived from Google Guava project, which is > >>> available under a "Apache License 2.0" license. > >>> (https://github.com/google/guava <https://github.com/google/guava>). > >>> > >>> This product contains code derived from the Netty Project, which is > >>> available under a "Apache License 2.0" license. > >>> (https://github.com/netty/netty <https://github.com/netty/netty>) > > First off license information should not be repeated in NOTICE [1], it > belongs in LICENSE and there no need to add URLs in NOTICE to repo unless it > is specified in the license conditions (so called required 3rd-party > notices). [2] > > The Guava project doesn’t have a NOTICE file so nothing needs to be added for > it. > > The Netty project has a long (and sadly IMO malformed) NOTICE file. > > I would suggest you just add: > > "This product contains code form the Netty Project: > > The Netty Project > ================= > Please visit the Netty web site for more information: > * http://netty.io/ > > Copyright 2014 The Netty Project”
I have committed the above content to master and 2.6.4-release. > > Normally I would not add the URL but as they have it in their NOTICE file we > should include it. [3] > > Also double check if any of the code copies from Netty is from anything > mentioned further down in Netty’s NOTICE file. If it is we would need to add > more to the NOTICE file. I also checked that the code copies from Netty is not listed in Netty’s NOTICE file. > > Thanks, > Justin > > 1. http://www.apache.org/dev/licensing-howto.html#mod-notice > 2. https://www.apache.org/legal/resolved.html#required-third-party-notices > 3. http://www.apache.org/dev/licensing-howto.html#alv2-dep > -- Best Regards！ Huxing
