There is no need to shade gson into dubbo.jar, just need depency gson library.
I have fixed it . https://github.com/apache/incubator-dubbo/pull/3246 Ian Luo <ian....@gmail.com> 于2019年1月16日周三 下午2:34写道： > We should not shade gson binaries into dubbo all in one jar file, even > though there's no license issue. It is simply we should not do this, > instead, we should make sure dubbo all in one jar should have a transitive > dependency to gson library. > > I noticed it's caused by'<include>com.google.code.gson:gson</include>' in > dubbo-all/pom.xml. We should fix it. > > Thanks, > -Ian. > > > On Tue, Jan 15, 2019 at 5:16 PM jun liu <ken.lj...@gmail.com> wrote: > > > I noticed that a third-party source code ‘com.google <http://com.google/ > >.gson.*’ > > has been compiled into the convenient maven binary jar of 2.7.0 - > > dubbo-2.7.0.jar : > > >>>> > > . > > ├── META-INF > > │ ├── DEPENDENCIES > > │ ├── LICENSE > > │ ├── MANIFEST.MF > > │ ├── NOTICE > > │ ├── assembly > > │ │ └── bin > > │ ├── compat > > │ │ └── dubbo.xsd > > │ ├── dubbo > > │ │ └── internal > > │ ├── dubbo.xsd > > │ ├── maven > > │ │ ├── com.alibaba > > │ │ ├── com.google.code.gson > > │ │ └── org.apache.dubbo > > │ ├── spring.handlers > > │ └── spring.schemas > > ├── com > > │ ├── alibaba > > │ │ ├── com > > │ │ └── dubbo > > │ └── google > > │ └── gson > > └── org > > └── apache > > └── dubbo > > > > > > Since this binary jar (dubbo-2.7.0.jar) will be included in the Apache > > Binary Release, should we update the LICENSE or NOTICE file in the Binary > > Release to announce the existence of these binary files? > > > > BTW, ‘com.google <http://com.google/>.gson’ is declared to be unde > Apache > > License 2.0. > > > > You can directly download the latest SNAPSHOT release of 2.7.0-SNAPSHOT > in > > here[1] and unzip and check the contents to better understand what I am > > trying to describe here. > > > > 1. > > > https://repository.apache.org/content/repositories/snapshots/org/apache/dubbo/dubbo/2.7.0-SNAPSHOT/ > > > > Jun > > > > > On Jan 13, 2019, at 5:58 PM, Huxing Zhang <hux...@apache.org> wrote: > > > > > > Hi Jun, > > > > > > Could you summarize the current status of the 2.7-release branch? > > > I see there are still several enhancement on this branch. > > > > > > As this is the first time to prepare for a release for me, I am trying > > > to walk through the release steps[1]. > > > I might try to deploy snapshot to maven repository. > > > > > > Once we feel it is ready to do the release, I will start the formal > > > release process. > > > > > > > > > [1] http://dubbo.apache.org/en-us/blog/prepare-an-apache-release.html > > > > > > > > > -- > > > Best Regards！ > > > Huxing > > > > > > On Mon, Jan 7, 2019 at 1:48 PM jun liu <ken.lj...@gmail.com> wrote: > > >> > > >>>> > > >>>> Nice work! > > >>>> > > >>>> I think we should let the community to participate more in the > release > > >>>> process, for example, > > >>>> 1. check out a release branch called 2.7.0-release > > >>>> 2. encourage people to check it out, test it and report if there is > > >>>> any regressions, bugs or issues. > > >>>> 3. while we are doing the test, we can start going through the ASF > > >>>> release process locally, once we think it is ready to start a formal > > >>>> release note, it can be done very quickly. > > >>>> > > >>>> By the way, we need decide the release manager of 2.7.0 release. Is > > >>>> there anyone who volunteer to do that? > > >> > > >> Sorry, I missed this mail. > > >> * 2.7.0-release has been created > > >> * we've froze the codebase, test is underway. > > >> > > >>> I'd like to be the release manager if no one is claiming it. > > >> > > >> Great, I can help you with the source/binary packaging and tagging > > things. > > >> > > >> Jun > > >> > > >>> On Jan 5, 2019, at 12:11 PM, Huxing Zhang <hux...@apache.org> wrote: > > >>> > > >>> Hi, > > >>> > > >>> On Fri, Dec 28, 2018 at 10:45 AM Huxing Zhang <hux...@apache.org> > > wrote: > > >>>> > > >>>> Nice work! > > >>>> > > >>>> I think we should let the community to participate more in the > release > > >>>> process, for example, > > >>>> 1. check out a release branch called 2.7.0-release > > >>>> 2. encourage people to check it out, test it and report if there is > > >>>> any regressions, bugs or issues. > > >>>> 3. while we are doing the test, we can start going through the ASF > > >>>> release process locally, once we think it is ready to start a formal > > >>>> release note, it can be done very quickly. > > >>>> > > >>>> By the way, we need decide the release manager of 2.7.0 release. Is > > >>>> there anyone who volunteer to do that? > > >>> > > >>> I'd like to be the release manager if no one is claiming it. > > >>>> > > >>>> On Thu, Dec 27, 2018 at 11:53 PM jun liu <ken.lj...@gmail.com> > wrote: > > >>>>> > > >>>>> Hi, All > > >>>>> > > >>>>> I am writing this mail to > > >>>>> > > >>>>> * Keep you refreshed of the latest status about v2.7.0. > > >>>>> * Call for efforts on code review and tests > > >>>>> * Discuss possible release schedules of v2.7.0. > > >>>>> > > >>>>> About v2.7, it’s going to be a milestone version, in which will > make > > some significant changes. Most importantly, we will complete all IP > > Clearance related works. Technically speaking, it’s from this version on > > that a Dubbo release starts fully follows the Apache rules (lawfully), > > totally independent from any other third-party organizations or > companies. > > Secondly, this version will include many new features that have received > > wide attention from the community, by supporting these features, we can > > better resolve the community’s long accumulated demands. Last but not > > least, we have made some architectural changes in this version, made > Dubbo > > closer to the micro-service architecture, take the newly introduced > > configuration center as an example, it can work both as the center of > > Externalized Configuration at startup and as the center of service > > management configurations at runtime. > > >>>>> > > >>>>> To summarize, the contents already included in the CodeBase are: > > >>>>> > > >>>>> * Config Center: Zookeeper, Apollo, Nacos > > >>>>> * Externalized Configuration > > >>>>> * Service governance enhancement: dynamic configuration & routing > > rule > > >>>>> * Repackage to 'org.apache.dubbo' > > >>>>> * Java 8 support > > >>>>> * Async programming support > > >>>>> > > >>>>> Most of the candidates listed above are in the proposal list that > we > > have discussed in some threads before. For a more detailed description of > > these features or how they are realized, you can refer to the draft > > development documentations within this link[1] > > >>>>> > > >>>>> Thanks to the efforts from the community (especially thank to Ian, > > CVictory and Minxuan), most of the development work has been completed > and > > a round of code review and regression test based on some basic use cases > > have been completed[2]. > > >>>>> Now I think it's time to prepare the formal release. One most > > important thing I think we should pay attention to is stability. We > should > > guarantee it's stable enough before release, so we may need to put more > > effort into code review and functional testing. Based on my understanding > > of the CodeBase, such tests may at least continue to last for about 1 > week, > > during this period we may need to `freeze the code`, which means only > > optimization and bugfix will be allowed. After that, we can continue to > > evaluate when to start the formal vote process. > > >>>>> > > >>>>> 1. https://github.com/apache/incubator-dubbo/issues/2919 > > >>>>> 2. > > > https://github.com/apache/incubator-dubbo-samples/tree/samples-for-2.7.0-SNAPSHOT > > >>>>> > > >>>>> Jun > > >>>>> > > >>>> > > >>>> > > >>>> -- > > >>>> Best Regards！ > > >>>> Huxing > > >>> > > >>> > > >>> > > >>> -- > > >>> Best Regards！ > > >>> Huxing > > >> > > > > > > > > > -- > > > Best Regards！ > > > Huxing > > > > > -- Best Regard! cvitory
