Hi, Ok, then I am willing to obey the opinions of the majority.
But I still keep my opinion. If I find that this kind of behavior will cause some problems, then it is not too late for me to raise this question again. Let's continue to do as we do now. Keep moving forward. :) Ian Luo <ian....@gmail.com> 于2019年4月10日周三 下午4:23写道： > Agree with YunKun's idea to enhance checkstyle rule in order to keep code > style consistent. In fact, we do have a code style guideline [1] for Idea's > user to import, is it sufficient? > > Thanks, > -Ian. > > 1. > > https://github.com/apache/incubator-dubbo/blob/master/CONTRIBUTING.md#code-style > > On Wed, Apr 10, 2019 at 1:23 PM YunKun Huang <hyun...@apache.org> wrote: > > > I think there should have a rule for polish. > > > > For example PR:https://github.com/apache/incubator-dubbo/pull/3651 > > If polish is necessary, I suggest also add a checkstyle rule for it. > > > > But for what kind of rule need apply, it need discuss first. for example, > > is it acceptable for single-line statements without braces etc.. > > > > On 2019/04/09 06:01:13, Huxing Zhang <hux...@apache.org> wrote: > > > Hi, > > > > > > I agree with Ian. I think small patches to polish code is acceptable. > > > People these days are getting busy, and might not have large amount of > > > time to contribute. > > > Meanwhile, the it is easy to review. Large size pull request can be > > > hard to review. > > > > > > On Tue, Apr 9, 2019 at 10:31 AM yuhang xiu <carry...@gmail.com> wrote: > > > > > > > > Hi, all > > > > > > > > Recently I found out that we have merged some pull requests for the > > polish > > > > code. > > > > > > > > I personally do not advocate small-scale polish code, such as this pr > > [1]. > > > > We can't see the improvement clearly. > > > > > > > > I think that for this pr, we should put it in a large-scale polish > > code, or > > > > bugfix and feature-related pr, rather than separate. > > > > > > > > It's important to note that I am not denying the importance of the > > polish > > > > code. I just think that these prs will disrupt our commits record. > > > > > > > > I have encountered this problem in the flink community. The flink > > community > > > > does not accept small-scale polish code pr. They suggested that this > > change > > > > should be placed in other prs. > > > > > > > > What do you think about this? > > > > > > > > [1] https://github.com/apache/incubator-dubbo/pull/3820/files > > > > > > > > > > > > -- > > > Best Regards！ > > > Huxing > > > > > >
