We have some integration test in https://github.com/apache/dubbo-samples . If you have installed docker in your computer, you can run it directly.
At round 1 of 2.7.4 release vote, I have run the integration test, and it work well. But before round 2 of 2.7.4 release vote, we try to fix an issue ( https://github.com/apache/dubbo/pull/5135) , and I didn't recheck the code and didn't run the integration test. It's my fault. Sorry for bringing you inconvenience. bailei <bailei...@163.com> 于2019年10月22日周二 上午11:33写道： > The fix code looks good to me. > I think we need a basic flow smoking unit test, such as:provider export > service->consumer subscribe -> consumer call -> validate what we expect.The > registry I suggest using a embedded zookeeper server. > Anyway,just a quick thought in my mind, I think the community will have > better solutions. > Finally, thank you for your attention and react with a quick fix. > > > > 在 2019年10月21日，下午6:18，Jun Liu <liu...@apache.org> 写道： > > > > Hi Bailei, Jason > > > >> But after updating to branch of 2.7.4 we continue to suffer the NPE > issue (Location AbstractInterfaceConfig.useRegistryForConfigIfNecessary > which is mentioned by @bailei). > > > > > > The issue you reported is indeed a serious issue that need to be fixed. > Though the Cvictory hasn’t announced the release notes yet, I noticed 2.7.4 > maven artifacts has been published to the central repo. Since a published > artifacts cannot and should not be removed or replaced, the only way to fix > this issue is to start a new release right now. I tend to use 2.7.4.1 as > the fix version. > > > > I have to say that his is a low level error and should be found before > package. From my perspective, I think mostly it's because of the poor UT > coverage. Besides, at that time, 2.7.4 has beed delayed for weeks for all > kinds of reasons and we were a bit hurry to release it and our vigilance > were lowered when the release cycle has been stretched so long. > > > > Below[1] is the patch I submitted fix this issue. Please help to check. > Keep posted, I will update if there's new progress. > > > > 1. https://github.com/apache/dubbo/pull/5205 > > > > Jun > > > >> On Oct 21, 2019, at 8:49 AM, Jason Joo <hblz...@163.com> wrote: > >> > >> -1. > >> > >> So will it be included in 2.7.4 or 2.7.5? > >> > >> One of our project using annotations came to introduce multiple > registries. But we found that there was a bug on subscribing same interface > from different registries before 2.7.3(inclusive) util #5033( > https://github.com/apache/dubbo/pull/5033) had been merged. > >> > >> But after updating to branch of 2.7.4 we continue to suffer the NPE > issue (Location AbstractInterfaceConfig.useRegistryForConfigIfNecessary > which is mentioned by @bailei). > >> > >> We will make a temporary build first in our private repository and I > suggest it is necessary being included in 2.7.4. Btw, `sonymoon` has > already given a fix in his repo ( > https://github.com/sonymoon/dubbo/commit/7b73f52349d7a37572bb724b28ec62e08d3a29fd > ). > >> > >> And more pls consider that how to solve the scanning problem mentioned > in issue #4895 (https://github.com/apache/dubbo/pull/4895) because it is > long time no response. It is not as urgent as the NPE issue. > >> > >> And I will close #4199 now and I think we'd better to describe it in > document for those which have mixed versions deployed in environment and > also have implemented MonitorService. (The simple solution is just copying > the legacy interface into project and public them together). > >> > >> best regards, > >> > >> Jason > >> > >>> On Oct 20, 2019, at 15:00, bailei <bailei...@163.com> wrote: > >>> > >>> -1. > >>> I don’t know if I am qualified from voting. > >>> Is 2.7.4 released? > >>> I think there is a issue need to be checked ( > https://github.com/apache/dubbo/issues/5186 < > https://github.com/apache/dubbo/issues/5186>). Fix me if I was wrong. > >>> > >>> > >>>> 在 2019年10月18日，上午9:46，victory <shenglic...@gmail.com> 写道： > >>>> > >>>> We’ve received 3 +1 binding votes and 2 +1 non-binding vote: +1 > binding, > >>>> Mercy Ma +1 binding, Justin Mclean +1 binding, Jun Liu +1 > non-binding, Lonre > >>>> Wang > >>>> +1 non-binding , 郑泽超 > >>>> > >>>> I will release dubbo-2.7.4 today. Best regards, The Apache Dubbo > >>>> (Incubating) Team > >>>> > >>>> Justin Mclean <jus...@classsoftware.com> 于2019年10月16日周三 上午10:58写道： > >>>> > >>>>> Hi, > >>>>> > >>>>> +1 (binding) > >>>>> > >>>>> I checked: > >>>>> - signatures and hashes fine > >>>>> - LICENSE and NOTICE OK > >>>>> - no unexpected binary files > >>>>> - source files have ASF headers > >>>>> - can compile from source > >>>>> > >>>>> RE the software grant normally when a copyright is removed and the > headers > >>>>> replaced you need to put something in NOTICE saying this was done. If > >>>>> original headers are left in there then this should be mentioned in > >>>>> LICENSE. I suggest you fix this in the next release > >>>>> > >>>>> Thanks, > >>>>> Justin > >>>> > >>>> > >>>> > >>>> -- > >>>> > >>>> Best Regard! > >>>> cvitory > >>> > >> > > -- Best Regard! cvitory
