Justin, I randomly pick HttpUtils to quick check. It has the license header shown below:
/* * Copyright (C) 2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ It does have the different license header than others, but I think it is fine. Pls. let me know if it is a show stopper for the current release. These files are originally made by Dubbo team. We can change the license header to be consistent with the official one at any time. Let me know your suggestion. Thanks, -Ian. On Fri, Mar 20, 2020 at 12:04 PM Justin Mclean <[email protected]> wrote: > Hi, > > -1 (binding) as code has incorrect headers > > I checked: > - signatures and hashes fine > - LICENSE and NOTICE are file > - No unexpected binary files > - Looks like these files [1][2][3] have incorrect header or may not be ASF > files, and may need to be mentioned in LICENSE. Where did they come from? > - I didn’t try compiling > > Thanks, > Justin > > 1. > ./dubbo-common/src/main/java/org/apache/dubbo/common/utils/HttpUtils.java > 2. > ./dubbo-metadata/dubbo-metadata-processor/src/test/java/org/apache/dubbo/metadata/rest/User.java > 3. > ./dubbo-metadata/dubbo-metadata-api/src/test/java/org/apache/dubbo/metadata/rest/User.java > >
