Do we have a checklist which we can run like Julian did, so we can avoid
some obvious issues.

Thanks
Edward

On 3/6/16, 8:11, "Dendukuri, Hemanth" <hdenduk...@ebay.com> wrote:

>Thanks Julial,for your valuable comments.
>
>The build was tested on JDK 1.7 and we don't yet support 1.8. I thing we
>should have called this out. We had ave jiras to call this out at right
>places and to add this improvement.
>https://issues.apache.org/jira/browse/EAGLE-187
>https://issues.apache.org/jira/browse/EAGLE-103
>
>
>Here is the link for the tag (release-0.3.0)
>https://github.com/apache/incubator-eagle/tags
>
>Regards 
>Hemanth Dendukuri 
>
>On Mar 5, 2016, at 1:57 PM, Julian Hyde <jh...@apache.org> wrote:
>
>>> Should this be voted in dev list or private list.
>> 
>> Dev list. Very few things in Apache need to happen in private.
>> 
>> The artifacts are in the right place, checksums look good, directory
>> structure of .tar.gz looks good.
>> 
>> There's no tag in git yet; I presume you intend to apply that later.
>> 
>> I unzipped .tar.gz and tried to build. Building using JDK 1.8 and
>> Maven 3.2.1 on Ubuntu, I got the following errors:
>> 
>> [INFO] --- maven-scala-plugin:2.15.0:compile (scala-compile-first) @
>> eagle-stream-process-base ---
>> [INFO] Checking for multiple versions of scala
>> [WARNING]  Expected all dependencies to require Scala version: 2.10.0
>> [WARNING]  org.apache.kafka:kafka_2.10:0.8.1.2.2.0.0-2041 requires
>> scala version: 2.10.4
>> [WARNING] Multiple versions of scala libraries detected!
>> [INFO] includes = [**/*.java,**/*.scala,]
>> [INFO] excludes = []
>> [INFO] 
>>/tmp/incubator-eagle-release-0.3.0/eagle-core/eagle-data-process/eagle-st
>>ream-process-base/src/main/java:-1:
>> info: compiling
>> [INFO] 
>>/tmp/incubator-eagle-release-0.3.0/eagle-core/eagle-data-process/eagle-st
>>ream-process-base/src/main/scala:-1:
>> info: compiling
>> [INFO] Compiling 16 source files to
>> 
>>/tmp/incubator-eagle-release-0.3.0/eagle-core/eagle-data-process/eagle-st
>>ream-process-base/target/classes
>> at 1457213608788
>> [ERROR] error: error while loading CharSequence, class file
>> '/usr/lib/jvm/jdk1.8.0_72/jre/lib/rt.jar(java/lang/CharSequence.class)'
>> is broken
>> [INFO] (class java.lang.RuntimeException/bad constant pool tag 18 at
>>byte 10)
>> [ERROR] error: error while loading AnnotatedElement, class file
>> 
>>'/usr/lib/jvm/jdk1.8.0_72/jre/lib/rt.jar(java/lang/reflect/AnnotatedEleme
>>nt.class)'
>> is broken
>> [INFO] (class java.lang.RuntimeException/bad constant pool tag 18 at
>>byte 76)
>> [ERROR] error: error while loading ConcurrentMap, class file
>> 
>>'/usr/lib/jvm/jdk1.8.0_72/jre/lib/rt.jar(java/util/concurrent/ConcurrentM
>>ap.class)'
>> is broken
>> [INFO] (class java.lang.RuntimeException/bad constant pool tag 18 at
>>byte 61)
>> [ERROR] three errors found
>> 
>> There are 3 .jar files present (bootstream.jar, commons-daemon.jar,
>> tomcat-juli.jar). I guess that is a binary distribution of
>> apache-tomcat?
>> 
>> Checked DISCLAIMER, LICENSE present. There should be a NOTICE file,
>> and the additions to that you made to the LICENSE file for fonts
>> should instead be in the NOTICE file.
>> 
>> I checked that there were instructions on how to build in README.md.
>> Would be useful if it stated which JDKs are supported. I assumed 1.8.
>> 
>> The version number in pom.xml is 0.3.0, should include "incubating",
>> say 0.3.0-incubating.
>> 
>> My vote:
>> 
>> [x] -1 Do not release this package because there is no NOTICE file,
>> and because there are binary files, and because the release does not
>> build.
>> 
>> Julian
>> 
>>> On Sat, Mar 5, 2016 at 9:00 AM, Hao Chen <h...@apache.org> wrote:
>>> +1
>>> 
>>> Thanks very much Hemanth for raising vote for the first release of
>>>Eagle.
>>> 
>>> Regards,
>>> Hao
>>> 
>>> On Fri, Mar 4, 2016 at 9:31 PM, arun karthick manoharan <
>>> aruncarth...@gmail.com> wrote:
>>> 
>>>> Should this be voted in dev list or private list.
>>>> 
>>>> +1
>>>> 
>>>> Thanks Hemanth for your support and guidance.
>>>> 
>>>> - Arun
>>>> Sent from my iPhone
>>>> 
>>>>>> On Mar 5, 2016, at 10:31 AM, Edward Zhang <yonzhang2...@apache.org>
>>>>> wrote:
>>>>> 
>>>>> +1
>>>>> 
>>>>> Thanks for taking care of this first incubator Eagle release,
>>>>>Hemanth.
>>>>> 
>>>>> Thanks
>>>>> Edward
>>>>> 
>>>>> On Fri, Mar 4, 2016 at 7:38 PM, Dendukuri, Hemanth
>>>>><hdenduk...@ebay.com>
>>>>> wrote:
>>>>> 
>>>>>> Hi all,
>>>>>> 
>>>>>> 
>>>>>>      This is the incubator release of Apache Eagle, 0.3.0.
>>>>>> 
>>>>>>      Thanks to everyone who has contributed to this release.
>>>>>> 
>>>>>>      HereĀ¹s release notes:
>>>> 
>>>>https://git-wip-us.apache.org/repos/asf?p=incubator-eagle.git;a=blob_pl
>>>>ain;f=CHANGELOG.txt;hb=refs/heads/branch-0.3.0
>>>>>> 
>>>>>>      The artifacts to be voted on are located here:
>>>> 
>>>>https://dist.apache.org/repos/dist/dev/incubator/eagle/0.3.0-incubating
>>>>/
>>>>>> 
>>>>>>      The commit to be voted upon:
>>>> 
>>>>https://github.com/apache/incubator-eagle/commit/d9ef76d9756fbf7c899291
>>>>8b6f99fa2ca4c392fd
>>>>>> 
>>>>>>      Release artifacts are signed with the following key:
>>>>>> https://people.apache.org/keys/committer/hdendukuri.asc
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> The hashes of the artifacts are as follows:
>>>>>> 
>>>>>> apache-eagle-0.3.0-incubating-src.tar.gz.md5
>>>>>> c8d88e11c782e2e88e9909e6dcc0d47e
>>>>>> 
>>>>>> apache-eagle-0.3.0-incubating-src.tar.gz.sha
>>>>>> 08640f2041847dd719c72d950ade9ea55a0ca870
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>>      The vote is open for the next 72 hours and passes if a
>>>>>>majority of
>>>>>> at least three +1 PPMC votes are cast.
>>>>>> 
>>>>>>       [ ] +1 Release this Eagle 0.3.0 Incubator Version.
>>>>>> 
>>>>>>       [ ]  0 I don't feel strongly about it, but I'm okay with the
>>>>>> release
>>>>>> 
>>>>>>       [ ] -1 Do not release this package because...
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> Thanks,
>>>>>> 
>>>>>> Hemanth Dendukuri
>>>> 

Reply via email to