Couple of other notes :
- I see bunch of .js and .css files, and all of them licensed under Apache License. Please make sure none of them are copied files - wrongly attached with Apache license. - More binary files seen, please take care of not bundling them in next candidate : ./eagle-external/eagle-ambari/lib/EAGLE/package/patches/app.js.gz Thanks Amareshwari On Mon, Mar 7, 2016 at 11:51 AM, Amareshwari Sriramdasu < amareshw...@apache.org> wrote: > Build with -DskipTests failed on Java7 as well : > > =============== Web APP Building Start =============== > > Environment Check... > > npm not installed! > > Can you mention what needs to be installed in README and how to? > > Thanks > > Amareshwari > > > > On Mon, Mar 7, 2016 at 11:42 AM, Amareshwari Sriramdasu < > amareshw...@apache.org> wrote: > >> -1 (Binding). >> >> + Verified Signature. Looks OK >> + MD5 checksum looks good. >> - Could not verify, as I could not find which SHA is published. Tried >> both SHA1 and SHA512. None matched. Can you put the file extension with >> actual encoding. SHA512 is recommended in apache releases. See >> http://www.apache.org/dev/release-signing.html#sha-checksum >> - NOTICE needs changes. >> >> MIT licenses need not be mentioned in NOTICE file : >> http://www.apache.org/dev/licensing-howto.html#permissive-deps. >> >> For bundling Category B licensed files, NOTICE should be updated on how >> to obtain them - a website link will do. >> What are the source files with SIL Open Font License, 1.1? You might need >> to include how to obtain them in the NOTICE file. >> >> - License has issues. Updated below. >> - Tests failed for me : >> >> Failed tests: >> >> testRound2(org.apache.eagle.common.TestDateTimeUtil) >> - Build on Java-8 failed . You might want to say it explicitly in README, >> which Java it would work with. >> >> ---- >> >> [INFO] eagle-stream-process-base .......................... FAILURE >> [02:05 min] >> >> [INFO] /Users/ >> amareshwari.sr/Downloads/eagle-release/incubator-eagle-release-0.3.0/eagle-core/eagle-data-process/eagle-stream-process-base/src/main/java:-1: >> info: compiling >> >> [INFO] /Users/ >> amareshwari.sr/Downloads/eagle-release/incubator-eagle-release-0.3.0/eagle-core/eagle-data-process/eagle-stream-process-base/src/main/scala:-1: >> info: compiling >> >> [INFO] Compiling 16 source files to /Users/ >> amareshwari.sr/Downloads/eagle-release/incubator-eagle-release-0.3.0/eagle-core/eagle-data-process/eagle-stream-process-base/target/classes >> at 1457328649257 >> >> Downloading: >> http://maven.scm.corp.inmobi.com/content/groups/public/org/scala-lang/scala-library/2.10.0/scala-library-2.10.0.jar >> >> Downloaded: >> http://maven.scm.corp.inmobi.com/content/groups/public/org/scala-lang/scala-library/2.10.0/scala-library-2.10.0.jar >> (6948 KB at 151.4 KB/sec) >> >> [ERROR] error: error while loading CharSequence, class file >> '/Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/jre/lib/rt.jar(java/lang/CharSequence.class)' >> is broken >> >> [INFO] (class java.lang.RuntimeException/bad constant pool tag 18 at byte >> 10) >> >> [ERROR] error: error while loading AnnotatedElement, class file >> '/Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/jre/lib/rt.jar(java/lang/reflect/AnnotatedElement.class)' >> is broken >> >> [INFO] (class java.lang.RuntimeException/bad constant pool tag 18 at byte >> 76) >> >> [ERROR] error: error while loading ConcurrentMap, class file >> '/Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/jre/lib/rt.jar(java/util/concurrent/ConcurrentMap.class)' >> is broken >> >> [INFO] (class java.lang.RuntimeException/bad constant pool tag 18 at byte >> 61) >> >> [ERROR] three errors found >> >> --- >> *Licensing issues:* >> >> >> - Top level license should have the full copy of the license of >> bundled source files, if they are non apache licensed. >> - Minor : You might want to correct the following copyrights to >> Apache Eagle or remove them : >> >> incubator-eagle-release-0.3.0//eagle-core/eagle-alert/eagle-alert-notification-plugin/src/main/resources/ALERT_DEFAULT.vm: >> <!-- Copyright --> >> >> incubator-eagle-release-0.3.0//eagle-core/eagle-alert/eagle-alert-notification-plugin/src/main/resources/ALERT_DEFAULT.vm: >> <p><a href=" >> http://123.xyz.com/alerts/alertlist.html";>Copyright 2014 @ Hadoop >> Eagle</a></p> >> >> incubator-eagle-release-0.3.0//eagle-core/eagle-alert/eagle-alert-process/src/main/resources/ALERT_DEFAULT.vm: >> <!-- Copyright --> >> >> incubator-eagle-release-0.3.0//eagle-core/eagle-alert/eagle-alert-process/src/main/resources/ALERT_DEFAULT.vm: >> <p><a href=" >> http://123.xyz.com/alerts/alertlist.html";>Copyright 2014 @ Hadoop >> Eagle</a></p> >> >> incubator-eagle-release-0.3.0//eagle-core/eagle-query/eagle-common/src/main/resources/templates/tec_alert.vm: >> Copyright © 2013 <a href=" >> http://123.dc1.xyz.com:9090/eagle-web/ui/eagle.html"; >> >> incubator-eagle-release-0.3.0//eagle-core/eagle-query/eagle-common/src/test/resources/templates/tec_alert.vm: >> Copyright © 2013 <a href=" >> http://123.dc1.xyz.com:9090/eagle-web/ui/eagle.html"; >> >> incubator-eagle-release-0.3.0//eagle-core/eagle-query/eagle-common/src/test/resources/templates/test_anomaly_alert.vm: >> Copyright © 2014 <a href=" >> http://hadoop-eagle.vip.dc1.xyz.com"; >> >> >> - Seeing WSO2 copyrights on the following files and they are apache >> licensed as well. Can you clarify whats happening here? >> >> incubator-eagle-release-0.3.0//eagle-core/eagle-policy/eagle-policy-base/src/main/java/org/apache/eagle/policy/siddhi/extension/ContainsIgnoreCaseExtension.java: >> * Copyright (c) 2015, WSO2 Inc. (http://www.wso2.org) All Rights >> Reserved. >> >> incubator-eagle-release-0.3.0//eagle-core/eagle-policy/eagle-policy-base/src/main/java/org/apache/eagle/policy/siddhi/extension/EqualsIgnoreCaseExtension.java: >> * Copyright (c) 2015, WSO2 Inc. (http://www.wso2.org) All Rights >> Reserved. >> >> incubator-eagle-release-0.3.0//eagle-core/eagle-policy/eagle-policy-base/src/main/java/org/apache/eagle/policy/siddhi/extension/RegexpIgnoreCaseFunctionExtension.java: >> * Copyright (c) 2015, WSO2 Inc. (http://www.wso2.org) All Rights >> Reserved. >> >> >> - Can you avoid bundling tomcat in source and pull them at compile >> time? >> >> $ls incubator-eagle-release-0.3.0//eagle-assembly/src/main/lib/tomcat/ >> >> LICENSE NOTICE RELEASE-NOTES RUNNING.txt bin conf lib >> >> $ ls >> incubator-eagle-release-0.3.0//eagle-assembly/src/main/lib/tomcat/bin/ >> >> bootstrap.jar commons-daemon.jar daemon.sh setclasspath.sh startup.sh >> tool-wrapper.sh >> >> catalina.sh configtest.sh digest.sh shutdown.sh tomcat-juli.jar >> version.sh >> Source release cannot have jar files getting bundled. They need to be >> removed. >> >> >> - Following files bundled seem to be MIT or BSD licensed. They need >> to be mentioned in top level NOTICE file. >> >> >> incubator-eagle-release-0.3.0//eagle-external/hadoop_jmx_collector/lib/six/six.py >> >> >> - Minor : RAT check during "clean package" fails. You might have to >> create log files in target : >> >> >> incubator-eagle-release-0.3.0/eagle-core/eagle-query/eagle-common/logs/eagle.log >> Thanks >> Amareshwari >> >> On Sat, Mar 5, 2016 at 9:08 AM, Dendukuri, Hemanth <hdenduk...@ebay.com> >> wrote: >> >>> Hi all, >>> >>> >>> This is the incubator release of Apache Eagle, 0.3.0. >>> >>> Thanks to everyone who has contributed to this release. >>> >>> Here’s release notes: >>> https://git-wip-us.apache.org/repos/asf?p=incubator-eagle.git;a=blob_plain;f=CHANGELOG.txt;hb=refs/heads/branch-0.3.0 >>> >>> The artifacts to be voted on are located here: >>> https://dist.apache.org/repos/dist/dev/incubator/eagle/0.3.0-incubating/ >>> >>> The commit to be voted upon: >>> https://github.com/apache/incubator-eagle/commit/d9ef76d9756fbf7c8992918b6f99fa2ca4c392fd >>> >>> Release artifacts are signed with the following key: >>> https://people.apache.org/keys/committer/hdendukuri.asc >>> >>> >>> >>> The hashes of the artifacts are as follows: >>> >>> apache-eagle-0.3.0-incubating-src.tar.gz.md5 >>> c8d88e11c782e2e88e9909e6dcc0d47e >>> >>> apache-eagle-0.3.0-incubating-src.tar.gz.sha >>> 08640f2041847dd719c72d950ade9ea55a0ca870 >>> >>> >>> >>> The vote is open for the next 72 hours and passes if a majority >>> of at least three +1 PPMC votes are cast. >>> >>> [ ] +1 Release this Eagle 0.3.0 Incubator Version. >>> >>> [ ] 0 I don't feel strongly about it, but I'm okay with the >>> release >>> >>> [ ] -1 Do not release this package because... >>> >>> >>> >>> Thanks, >>> >>> Hemanth Dendukuri >>> >> >> >
