[
https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430301#comment-15430301
]
ASF GitHub Bot commented on EAGLE-411:
--------------------------------------
GitHub user chitin opened a pull request:
https://github.com/apache/incubator-eagle/pull/372
EAGLE-411 Refactor hbase related unit test cases with mockito
EAGLE-411 Refactor hbase related unit test cases with mockito
- Mock the action of HBase reading, mock the meanful result of
scanner.next(), unit test would not be enslaved to HBase.
https://issues.apache.org/jira/browse/EAGLE-411.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chitin/incubator-eagle EAGLE411
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/372.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #372
----
commit b8ac17fa76ea97768dab6dc929209439a5860c07
Author: chitin <chitin1...@gmail.com>
Date: 2016-08-22T08:29:44Z
EAGLE-411 Refactor hbase related unit test cases with mockito and mini-hbase
--Mock the action of HBase reading, mock the meanful result of
scanner.next(), unit test would not be enslaved to HBase.
https://issues.apache.org/jira/browse/EAGLE-411.
----
> Refactor hbase related unit test cases with mockito and mini-hbase
> ------------------------------------------------------------------
>
> Key: EAGLE-411
> URL: https://issues.apache.org/jira/browse/EAGLE-411
> Project: Eagle
> Issue Type: Improvement
> Affects Versions: v0.3.0, v0.4.0
> Reporter: Hao Chen
> Assignee: Chang chen
> Labels: unit-test
> Fix For: v0.5.0
>
>
> Current implementation is really not stable which cause unit test like
> TestHBaseLogReader2 unable to pass in meanful time, we need a better version.
> https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java
> http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
