[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430817#comment-15430817 ]
ASF GitHub Bot commented on EAGLE-411: -------------------------------------- Github user baibaichen commented on the issue: https://github.com/apache/incubator-eagle/pull/374 @haoch , I think we need write a new test class instead of modifying TestHBaseLogReader2. > Refactor hbase related unit test cases with mockito and mini-hbase > ------------------------------------------------------------------ > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement > Affects Versions: v0.3.0, v0.4.0 > Reporter: Hao Chen > Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)