100pah commented on a change in pull request #9210: fix #9182 Graph label.rotate is invalid URL: https://github.com/apache/incubator-echarts/pull/9210#discussion_r225526584
########## File path: src/chart/graph/GraphView.js ########## @@ -222,7 +227,7 @@ export default echarts.extendChartView({ } else { symbolPath.setStyle({ - textRotation: 0 + textRotation: labelRotate *= Math.PI / 180 Review comment: If `labelRotate` is defined outside the loop and not be reset in the beginning of each loop, using `*=` is probably incorrect. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org