100pah commented on a change in pull request #9210: fix #9182 Graph
label.rotate is invalid
URL: https://github.com/apache/incubator-echarts/pull/9210#discussion_r225525322
##########
File path: src/chart/graph/GraphView.js
##########
@@ -200,7 +200,12 @@ export default echarts.extendChartView({
&& seriesModel.get('circular.rotateLabel');
var cx = data.getLayout('cx');
var cy = data.getLayout('cy');
+ var labelRotate = seriesModel.get('label.rotate') || 0;
data.eachItemGraphicEl(function (el, idx) {
+ var itemRotate = itemModel.get('label.rotate');
+ if (itemRotate != undefined) {
Review comment:
By convention, `some != null` is recommended. (not a bit deal, just probably
because that null can not be redefined)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org
