100pah commented on a change in pull request #8997: Pie chart adds filterValue
parameter
URL: https://github.com/apache/incubator-echarts/pull/8997#discussion_r225531517
##########
File path: src/chart/pie/PieView.js
##########
@@ -211,7 +211,20 @@ piePieceProto.updateData = function (data, idx,
firstCreate) {
graphic.setHoverStyle(this);
};
-piePieceProto._updateLabel = function (data, idx) {
+piePieceProto._getFilterIgnore = function(data, idx) {
Review comment:
(1) Code style: should be `function (data, idx)`, for anonymous function
declaration.
(2) Both `get`, `filter`, and `ignore` are verb. that makes the function
name a bit strange. Should the name has some relationship with
`labelDisplayThreshold`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org
