100pah commented on a change in pull request #8997: Pie chart adds filterValue
parameter
URL: https://github.com/apache/incubator-echarts/pull/8997#discussion_r225534419
##########
File path: src/chart/pie/PieView.js
##########
@@ -211,7 +211,20 @@ piePieceProto.updateData = function (data, idx,
firstCreate) {
graphic.setHoverStyle(this);
};
-piePieceProto._updateLabel = function (data, idx) {
+piePieceProto._getFilterIgnore = function(data, idx) {
+ var seriesModel = data.hostModel;
+ var itemModel = data.getItemModel(idx);
Review comment:
create an `itemModel` is not necessary here (and should not fetch value from
itemModel). Just using `data.get(valueDim, idx)` the get the value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
