+1 (binding) I checked: - The release file is in the right location - sha512 and asc is correct. - Version is correct in package.json and src/core/echarts.ts - The source code is the same as the GitHub tag "5.3.2-rc.1". - LICENSE is correct. - RELEASE_NOTE exists and is correct. - Download and npm install and build OK. - Can run examples from build.
Thanks, ------------------------------ Su Shuang (100pah) ------------------------------ On Wed, 30 Mar 2022 at 12:43, Zhongxiang Wang <wan...@apache.org> wrote: > Hi Ville, Thanks for your vote. Your suggestion sounds great. We'll try to > add this link in the next release. > > Regards. > > > On Tue, Mar 29, 2022 at 10:15 PM Ville Brofeldt < > ville.v.brofe...@gmail.com> > wrote: > > > Hi all, > > > > +1 (non-binding), tested with master branch of Apache Superset, works as > > expected. And thanks for making the rc available on npm again. Just as an > > idea, it could be a nice addition to add a link to > > https://www.npmjs.com/package/echarts/v/5.3.2-rc.1 < > > https://www.npmjs.com/package/echarts/v/5.3.2-rc.1> to the vote email to > > make it more widely known that the rc is also available for testing on > npm. > > > > Btw, thanks to the ECharts team for making releases so frequently! > > > > Ville > > > > > On 28. Mar 2022, at 13.07, Zhongxiang Wang <wan...@apache.org> wrote: > > > > > > Dear community, > > > > > > We are pleased to be calling this vote for the release of Apache > ECharts > > > 5.3.2 (release candidate 1). > > > > > > The release candidate to be voted over is available at: > > > https://dist.apache.org/repos/dist/dev/echarts/5.3.2-rc.1/ > > > > > > The release candidate is signed with a GPG key available at: > > > https://dist.apache.org/repos/dist/dev/echarts/KEYS > > > > > > The Git commit for this release is: > > > > > > https://gitbox.apache.org/repos/asf?p=echarts.git;a=commit;h=8b2a4c4fa878b8b1147b7d14356124ccc947cf2a > > > > > > The Release Note is available in: > > > > > > https://dist.apache.org/repos/dist/dev/echarts/5.3.2-rc.1/RELEASE_NOTE.txt > > > > > > Build Guide: > > > https://github.com/apache/echarts/blob/5.3.2-rc.1/README.md#build > > > > > > NPM Install: > > > npm i echarts@5.3.2-rc.1 > > > > > > Please vote on releasing this package as: > > > Apache ECharts 5.3.2 (release candidate 1) > > > by "2022-03-31T20:37:28.929Z". > > > > > > [ ] +1 Release this package > > > [ ] 0 I don't feel strongly about it, but don't object > > > [ ] -1 Do not release this package because... > > > > > > Anyone can participate in testing and voting, not just committers, > please > > > feel free to try out the release candidate and provide your votes. > > > > > > A checklist for reference: > > > > > > https://cwiki.apache.org/confluence/display/ECHARTS/Apache+ECharts+Release+Checklist > > > > > > Thanks! > > > > >
