“target” dir and its contents are leftover cruft in the local git clone from
the, now dysfunctional, ant build tooling.
Someone starting with a new clone/workspace should never encounter that in the
constructed src bundle.
But yeah, best to make the src bundle construction more exclusionary to be safe.
Don’t really want to add more cleanup processing in the gradle tooling to
remove (old) ant generated artifacts or eclipse build generated artifacts.
Good catch on the java7/classes.{in,out}/…/*.class
Thanks, including the changes to build.gradle to address these!
— Dale
> On Oct 22, 2016, at 7:35 PM, Justin Mclean <jus...@classsoftware.com> wrote:
>
> Hi,
>
> I check tried to compile the release branch and run into an issue with the
> javadoc and non-ascii characters which I fixed. I noticed the README also has
> some non ascii characters in it
>
> When I do a “cradle release” I end up with these in the source directory:
> +
> edgent-1.0.0-SNAPSHOT-20161023-1018-src/target/java8/ext/google-gson-2.2.4/gson-2.2.4-sources.jar
> +
> edgent-1.0.0-SNAPSHOT-20161023-1018-src/target/java8/ext/google-gson-2.2.4/gson-2.2.4.jar
> +
> edgent-1.0.0-SNAPSHOT-20161023-1018-src/target/java8/ext/metrics-3.1.2/metrics-core-3.1.2-sources.jar
> +
> edgent-1.0.0-SNAPSHOT-20161023-1018-src/target/java8/ext/metrics-3.1.2/metrics-core-3.1.2.jar
> +
> edgent-1.0.0-SNAPSHOT-20161023-1018-src/target/java8/ext/slf4j-1.7.12/slf4j-api-1.7.12.jar
> +
> edgent-1.0.0-SNAPSHOT-20161023-1018-src/target/java8/ext/slf4j-1.7.12/slf4j-jdk14-1.7.12.jar
> +
> edgent-1.0.0-SNAPSHOT-20161023-1018-src/target/java8/lib/edgent.api.function.jar
>
> Having jars in a source release will not pass a vote on the incubator. Is
> this possible that clean is cleaning up everything it needs to?
>
> Thanks,
> Justin
