Yup, just noticed it. Looking good!

> On Jun 14, 2017, at 11:36 AM, Christofer Dutz <christofer.d...@c-ware.de> 
> wrote:
> 
> Ok, so I just pushed a major update.
> 
> On my machine with these changes both the java7 and java8 builds seem to be 
> working. In the next few days I’ll probably play around with some of the 
> excluded modules and see if we can include them in the java7 build. Right 
> now, it sort of looks as if they were excluded simply because they didn’t 
> immediately work. So I’ll go through them and try to find out which ones we 
> can add and write down why some cant (This information seems to be missing at 
> the moment)
I suggest deferring the “add more to java7” effort until everything else needed 
to reach the state of being able to develop and make a release with the new 
machinery is done.  Maybe deferring until after actually making a release with 
the new machinery - IMO we should do one asap.

> Another thing I did, was to add the RAT plugin, go through the exclusions and 
> clean up the exclusions. Some were excluding stuff that shouldn’t be excluded 
> and it reported quite a hand full of files without ASF headers. I added them 
> so please have a look if this was ok.
LGTM

> 
> The Eclipse support is also on my list (even if I have to admit that I always 
> hate having to open that IDE ;-) )
:-) the sooner the better so that more folks can pull in the PR to experiment.

Thanks!
— Dale

Reply via email to