Hi Dale,
I just tested your script and it worked perfectly :-)
Regarding your observations:
- You mentioned in another post, that I should exclude any transitive
dependency of Kafka … The only valid reason I could see to need this, if using
Edgent in an environment in which Kafka is provided by other means. The Maven
way to handle such a situation is to mark that dependency “provided” in which
case it is used during compilation, but is excluded from being pulled in
automatically … like the servlet-api jars which usually are provided by every
servlet container.
- I’ll investigate why the animal-sniffer-annotations and alike are included …
I guess they shouldn’t. The reason for a different Jetty version in Java7, is
that the version used in java8 is not compatible with java7, so I had to go
back to the newest Jetty version that supports Java7.
Just forked the Maven-Wrapper project and will start working on a version of it
that works without a checked in jar. Any other solution (excluding jar from the
release) sounds like a hack and it would break the one requirement of Apache
releases, that you should be able to download and unpack the release and simply
run it to reproduce the same results. I guess the changes to the wrapper needed
here are minimal and if we had them all Apache projects could easily use that
versions without any problems.
Chris
Am 12.07.17, 19:37 schrieb "Dale LaBossiere" <dml.apa...@gmail.com>:
Chris,
I’ve uploaded a new version of get-edgent-jars.sh to
https://paste.apache.org/VuU3 <https://paste.apache.org/VuU3>
After you’ve built the j8,j7,android platforms you can do the following to
get the jars:
sh get-edgent-jars.sh --platform java8 --version 1.2.0-SNAPSHOT
sh get-edgent-jars.sh --platform java7 --version 1.2.0-SNAPSHOT
sh get-edgent-jars.sh --platform android --version 1.2.0-SNAPSHOT
I’m seeing some odd results that I believe are purely a result of what the
Edgent poms have in them (I think I have your most recent changes).
Comparing what’s collected for j8 vs j7 vs android…
- with the “provided” that was recently added, the kafka_2.10-0.8.2.2.jar
(and deps) are “missing” from j8,j7,android
- j8 vs j7 ext-jars - there are extra jars in j7 like
animal-sniffer-annotations-1.14 and others; there are different versions of
jetty jars
- j8 vs android ext-jars - similar extra jars in android
— Dale
