Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-edgent-samples/pull/5#discussion_r152813897
--- Diff: apps/pom.xml ---
@@ -37,38 +37,32 @@
<dependency>
<groupId>${edgent.runtime.groupId}</groupId>
<artifactId>edgent-analytics-sensors</artifactId>
- <version>${edgent.runtime.version}</version>
</dependency>
<dependency>
<groupId>${edgent.runtime.groupId}</groupId>
<artifactId>edgent-connectors-file</artifactId>
- <version>${edgent.runtime.version}</version>
</dependency>
<dependency>
<groupId>${edgent.runtime.groupId}</groupId>
<artifactId>edgent-analytics-math3</artifactId>
- <version>${edgent.runtime.version}</version>
</dependency>
<dependency>
<groupId>${edgent.runtime.groupId}</groupId>
<artifactId>edgent-connectors-iot</artifactId>
- <version>${edgent.runtime.version}</version>
</dependency>
<dependency>
<groupId>${edgent.runtime.groupId}</groupId>
<artifactId>edgent-connectors-iotp</artifactId>
- <version>${edgent.runtime.version}</version>
</dependency>
<dependency>
<groupId>${edgent.runtime.groupId}</groupId>
<artifactId>edgent-connectors-mqtt</artifactId>
- <version>${edgent.runtime.version}</version>
</dependency>
<dependency>
- <groupId>${project.groupId}</groupId>
+ <groupId>org.apache.edgent</groupId>
--- End diff --
Woops, I was wrong about this: This groupId change will break building the
samples for java7.
But, I think it should be reverted to its original value (same rationale as
for version below).
Also, I think the following change to version is neither necessary nor
desirable (since project.version is a static value defined in the pom itself).
I'll note there are similar occurrences in other poms (connectors,
scenarios,topology) that weren't changed and those apparently didn't cause a
problem.
---
