Github user chrisdutz commented on a diff in the pull request:

    
https://github.com/apache/incubator-edgent-samples/pull/5#discussion_r152833546
  
    --- Diff: apps/pom.xml ---
    @@ -37,38 +37,32 @@
         <dependency>
           <groupId>${edgent.runtime.groupId}</groupId>
           <artifactId>edgent-analytics-sensors</artifactId>
    -      <version>${edgent.runtime.version}</version>
         </dependency>
         <dependency>
           <groupId>${edgent.runtime.groupId}</groupId>
           <artifactId>edgent-connectors-file</artifactId>
    -      <version>${edgent.runtime.version}</version>
         </dependency>
         <dependency>
           <groupId>${edgent.runtime.groupId}</groupId>
           <artifactId>edgent-analytics-math3</artifactId>
    -      <version>${edgent.runtime.version}</version>
         </dependency>
         <dependency>
           <groupId>${edgent.runtime.groupId}</groupId>
           <artifactId>edgent-connectors-iot</artifactId>
    -      <version>${edgent.runtime.version}</version>
         </dependency>
         <dependency>
           <groupId>${edgent.runtime.groupId}</groupId>
           <artifactId>edgent-connectors-iotp</artifactId>
    -      <version>${edgent.runtime.version}</version>
         </dependency>
         <dependency>
           <groupId>${edgent.runtime.groupId}</groupId>
           <artifactId>edgent-connectors-mqtt</artifactId>
    -      <version>${edgent.runtime.version}</version>
         </dependency>
         
         <dependency>
    -      <groupId>${project.groupId}</groupId>
    +      <groupId>org.apache.edgent</groupId>
    --- End diff --
    
    But I also think: In contrast to the Edgent libs themselves it would be 
safe to fix the samples against one platform. After all they are examples no 
production-ready solutions.


---

Reply via email to