----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37313/#review95564 -----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java (line 755) <https://reviews.apache.org/r/37313/#comment150575> java doc missing falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java (line 763) <https://reviews.apache.org/r/37313/#comment150576> java doc here and method below. falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java (line 794) <https://reviews.apache.org/r/37313/#comment150577> is it possible to have some common code from assertInstances ? if not, lets name assertInstances as assertProcessInstance falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java (line 807) <https://reviews.apache.org/r/37313/#comment150578> i dont know the functionality. Is checking for "PROCESS" correct here since method name is assertFeedInstances falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java (line 745) <https://reviews.apache.org/r/37313/#comment150579> get coordJobs.get(0) might not work in case of feeds , where we have 2 coords , retention and replication falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java (line 45) <https://reviews.apache.org/r/37313/#comment150580> it might be a good idea to put dev jira link here also, for future reference. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java (line 86) <https://reviews.apache.org/r/37313/#comment150581> some java doc abt test description and for data provider also falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java (line 114) <https://reviews.apache.org/r/37313/#comment150582> java doc for test and dp methods. - samarth gupta On Aug. 10, 2015, 7:40 p.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37313/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 7:40 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1387 > https://issues.apache.org/jira/browse/FALCON-1387 > > > Repository: falcon-git > > > Description > ------- > > Test cases related to https://issues.apache.org/jira/browse/FALCON-1039 > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java > 85f3692 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java > 2baa35f > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java > f984457 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java > 4550666 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java > c68dd3c > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java > f327178 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java > c5dd0fd > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java > 6c8d4ee > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37313/diff/ > > > Testing > ------- > > Tested. > > > Thanks, > > PRAGYA MITTAL > >
