> On Aug. 17, 2015, 5:36 a.m., samarth gupta wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java, > > line 794 > > <https://reviews.apache.org/r/37313/diff/1/?file=1036573#file1036573line794> > > > > is it possible to have some common code from assertInstances ? if not, > > lets name assertInstances as assertProcessInstance
I tried doing that. But instance dependecy for process and feed produces different output and hence need to be handled separately. Will name assertInstances as assertProcessInstance > On Aug. 17, 2015, 5:36 a.m., samarth gupta wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java, > > line 755 > > <https://reviews.apache.org/r/37313/diff/1/?file=1036573#file1036573line755> > > > > java doc missing Will add java doc. > On Aug. 17, 2015, 5:36 a.m., samarth gupta wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java, > > line 763 > > <https://reviews.apache.org/r/37313/diff/1/?file=1036573#file1036573line763> > > > > java doc here and method below. Will add java doc. > On Aug. 17, 2015, 5:36 a.m., samarth gupta wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java, > > line 45 > > <https://reviews.apache.org/r/37313/diff/1/?file=1036578#file1036578line45> > > > > it might be a good idea to put dev jira link here also, for future > > reference. Sure. > On Aug. 17, 2015, 5:36 a.m., samarth gupta wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java, > > line 86 > > <https://reviews.apache.org/r/37313/diff/1/?file=1036578#file1036578line86> > > > > some java doc abt test description and for data provider also Will add java doc. > On Aug. 17, 2015, 5:36 a.m., samarth gupta wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java, > > line 114 > > <https://reviews.apache.org/r/37313/diff/1/?file=1036579#file1036579line114> > > > > java doc for test and dp methods. Will add java doc. - PRAGYA ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37313/#review95564 ----------------------------------------------------------- On Aug. 10, 2015, 7:40 p.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37313/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 7:40 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1387 > https://issues.apache.org/jira/browse/FALCON-1387 > > > Repository: falcon-git > > > Description > ------- > > Test cases related to https://issues.apache.org/jira/browse/FALCON-1039 > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java > 85f3692 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java > 2baa35f > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java > f984457 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java > 4550666 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java > c68dd3c > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java > f327178 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java > c5dd0fd > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java > 6c8d4ee > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/FeedInstanceDependencyTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/ProcessInstanceDependencyTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37313/diff/ > > > Testing > ------- > > Tested. > > > Thanks, > > PRAGYA MITTAL > >
