> On Nov. 19, 2015, 10:53 a.m., pavan kumar kolamuri wrote: > > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java, line 358 > > <https://reviews.apache.org/r/40474/diff/1/?file=1131864#file1131864line358> > > > > Please add touch in update method, update and touch can be grouped but > > not here
OK. Makes sense. > On Nov. 19, 2015, 10:53 a.m., pavan kumar kolamuri wrote: > > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java, > > line 256 > > <https://reviews.apache.org/r/40474/diff/1/?file=1131865#file1131865line256> > > > > did assertInstance method still required as you removed everywhere ? There are some places in ProcessInstanceManagerIT that still uses this method. So, its still required. > On Nov. 19, 2015, 10:53 a.m., pavan kumar kolamuri wrote: > > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java, line 196 > > <https://reviews.apache.org/r/40474/diff/1/?file=1131864#file1131864line196> > > > > Please change other places also Ok. Makes sense. > On Nov. 19, 2015, 10:53 a.m., pavan kumar kolamuri wrote: > > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java, line 352 > > <https://reviews.apache.org/r/40474/diff/1/?file=1131864#file1131864line352> > > > > Please add different test for summary, as it has lot of functionalities > > we can add later Yes I will add this. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40474/#review107156 ----------------------------------------------------------- On Nov. 19, 2015, 9:40 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40474/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 9:40 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1557 > https://issues.apache.org/jira/browse/FALCON-1557 > > > Repository: falcon-git > > > Description > ------- > > Entity Management Api's such as summary, list, submitAndSchedule, touch, etc. > and admin api should be supported by Falcon Unit > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java > 27b93c0 > client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 7262964 > oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java > 093d6ff > oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java > 6ae92de > prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java > ace21cb > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9f2b714 > > unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java > 42adc9a > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 42cb779 > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 2c8642d > > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java > 8dbbd7d > webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java > 37442c3 > > Diff: https://reviews.apache.org/r/40474/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > >
