> On Nov. 24, 2015, 4:18 a.m., Pallavi Rao wrote: > > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java, line 359 > > <https://reviews.apache.org/r/40474/diff/2/?file=1134010#file1134010line359> > > > > This will make the string start with a comma, doesn't it? The if > > condition should be after the property is appended (In which case you will > > have to handle the extra comma at the end.)
Its properties.length, not propertytList.length. Initially the length of properties is zero, so comma will not be appended. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40474/#review107708 ----------------------------------------------------------- On Nov. 20, 2015, 8:20 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40474/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 8:20 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1557 > https://issues.apache.org/jira/browse/FALCON-1557 > > > Repository: falcon-git > > > Description > ------- > > Entity Management Api's such as summary, list, submitAndSchedule, touch, etc. > and admin api should be supported by Falcon Unit > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java > 27b93c0 > client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 7262964 > oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java > 093d6ff > oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java > 6ae92de > prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java > ace21cb > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9f2b714 > > unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java > 42adc9a > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 42cb779 > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 2c8642d > > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java > 8dbbd7d > webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java > 37442c3 > > Diff: https://reviews.apache.org/r/40474/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > >
