> On Jan. 22, 2016, 11:39 p.m., Sowmya Ramesh wrote: > > common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java, > > line 295 > > <https://reviews.apache.org/r/42574/diff/1/?file=1204001#file1204001line295> > > > > Can hCatPartition.getParameters() return null?
>From the code, it looks like parameters is always set. But I agree with you >that we cant gaurantee it. Changing code to reflect that. > On Jan. 22, 2016, 11:39 p.m., Sowmya Ramesh wrote: > > common/src/main/java/org/apache/falcon/entity/CatalogStorage.java, line 399 > > <https://reviews.apache.org/r/42574/diff/1/?file=1204002#file1204002line399> > > > > What if FalconException is not because of PARTITION_DOES_NOT_EXIST? > > Don't we have to rethrow the exception after catching it? @peeyush and @sowmya - I was throwing exception in the patch I have on IDE, but somehow it didnt make it to the patch I submitted. Thanks for catching it. > On Jan. 22, 2016, 11:39 p.m., Sowmya Ramesh wrote: > > common/src/main/java/org/apache/falcon/entity/CatalogStorage.java, line 432 > > <https://reviews.apache.org/r/42574/diff/1/?file=1204002#file1204002line432> > > > > CatalogServiceFactory.getCatalogService().getPartition can return null. > > Isn't there a possibility that partition can be null? No, this partition is catalog partition created in HiveCatalogService, it cant be null. > On Jan. 22, 2016, 11:39 p.m., Sowmya Ramesh wrote: > > common/src/main/java/org/apache/falcon/entity/CatalogStorage.java, line 451 > > <https://reviews.apache.org/r/42574/diff/1/?file=1204002#file1204002line451> > > > > Can result be null or empty? Great catch, I found the same bug is in FileSystemStorage. Fixed it there as well. - Balu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42574/#review115953 ----------------------------------------------------------- On Jan. 20, 2016, 10:43 p.m., Balu Vellanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42574/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 10:43 p.m.) > > > Review request for Falcon, Ajay Yadava, Pallavi Rao, Sowmya Ramesh, and > Venkat Ranganathan. > > > Bugs: Falcon-763 > https://issues.apache.org/jira/browse/Falcon-763 > > > Repository: falcon-git > > > Description > ------- > > Support feed listing capability for catalog storage, as outlined in > FALCON-761 for FileSystemStorage. Falcon processes or feed replication > provides status on instances. When the instance status is WAITING for input, > users have difficulty in identifying what feed is missing. In general it > would very helpful to users to get feed availability status natively through > falcon. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java > 9e35782 > common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java > b988c3e > common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 143d9b4 > common/src/main/java/org/apache/falcon/entity/FeedHelper.java 8aa97ec > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java d565f94 > webapp/src/test/java/org/apache/falcon/catalog/CatalogStorageIT.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/42574/diff/ > > > Testing > ------- > > Added unit test, integration test and tested this end2end > > > Thanks, > > Balu Vellanki > >
