----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42574/#review116405 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/entity/CatalogStorage.java (line 409) <https://reviews.apache.org/r/42574/#comment177430> If this is required only for if can you move it inside if ? I know that control will not reach that line if it enters else but I think moving inside if will be more readable common/src/main/java/org/apache/falcon/entity/CatalogStorage.java (line 453) <https://reviews.apache.org/r/42574/#comment177431> result can be null isn't. get(0) will throw NPE if result is null. Check if result is null before trying to access it. Do the same for FileSystemStorage. - Sowmya Ramesh On Jan. 25, 2016, 9:01 p.m., Balu Vellanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42574/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 9:01 p.m.) > > > Review request for Falcon, Ajay Yadava, Pallavi Rao, Sowmya Ramesh, and > Venkat Ranganathan. > > > Bugs: Falcon-763 > https://issues.apache.org/jira/browse/Falcon-763 > > > Repository: falcon-git > > > Description > ------- > > Support feed listing capability for catalog storage, as outlined in > FALCON-761 for FileSystemStorage. Falcon processes or feed replication > provides status on instances. When the instance status is WAITING for input, > users have difficulty in identifying what feed is missing. In general it > would very helpful to users to get feed availability status natively through > falcon. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java > 9e35782 > common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java > b988c3e > common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 143d9b4 > common/src/main/java/org/apache/falcon/entity/FeedHelper.java 8aa97ec > common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java > 200f71f > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java d565f94 > webapp/src/test/java/org/apache/falcon/catalog/CatalogStorageIT.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/42574/diff/ > > > Testing > ------- > > Added unit test, integration test and tested this end2end > > > Thanks, > > Balu Vellanki > >
