> On Feb. 18, 2016, 7:16 a.m., sandeep samudrala wrote: > > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java, > > line 579 > > <https://reviews.apache.org/r/41916/diff/4/?file=1240484#file1240484line579> > > > > In case of a feed which has no replication and lifecycle retention is > > defined. > > Then it would validate only the queue in the lifecycle retention and > > not the one mentioned in the properties in the feed definition. > > > > Should that be fine. I feel, both the queues mentioned in the feed > > definition needs to be validate. Thoughts please
That should be fine. Validates in the following order: 1. if retention is enabled, 1a. check for the queue name specified in the lifecycle 1b. if not, use the queue name from the property 2. if replication is enabled, 2a. check the queue name from property - Venkatesan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41916/#review119594 ----------------------------------------------------------- On Feb. 11, 2016, 11:53 p.m., Venkatesan Ramachandran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41916/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 11:53 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Validate the hadoop cluster queue name specified in the Feed entity during > feed submit. > > The implementation uses Resource Manager REST API to get hadoop cluster queue > names. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/EntityUtil.java 24dbf3d > common/src/main/java/org/apache/falcon/entity/FeedHelper.java b3aaaab > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java > 981e730 > > common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java > 10a5265 > common/src/main/java/org/apache/falcon/util/HadoopQueueUtil.java > PRE-CREATION > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 95d10c4 > common/src/test/java/org/apache/falcon/util/HadoopQueueUtilTest.java > PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-1.json > PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-2.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/41916/diff/ > > > Testing > ------- > > Unit tests > Manual end to end tests > Secure cluster test > > > Thanks, > > Venkatesan Ramachandran > >
