----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41916/#review118751 -----------------------------------------------------------
Ship it! Fix it and ship it. Code looks good. common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java (line 588) <https://reviews.apache.org/r/41916/#comment180050> Minor Nit : This check is not necessary for Set and HashSet common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 1273) <https://reviews.apache.org/r/41916/#comment180052> Nit : Look in ClusterHelper.java at method getPropertyValue(Cluster cluster, String propName). It is much cleaner to implement a similar method in FeedHelper and use that. Also, please use a String constant for "queueName" as it is used in multiple locations. common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java (line 330) <https://reviews.apache.org/r/41916/#comment180056> Nit : Please use string constant for "queueName" as it is used in multiple locations. One suggested location is EntityUtil.java - Balu Vellanki On Feb. 10, 2016, 10:32 p.m., Venkatesan Ramachandran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41916/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 10:32 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Validate the hadoop cluster queue name specified in the Feed entity during > feed submit. > > The implementation uses Resource Manager REST API to get hadoop cluster queue > names. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java b3aaaab > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java > 981e730 > > common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java > 10a5265 > common/src/main/java/org/apache/falcon/util/HadoopQueueUtil.java > PRE-CREATION > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 95d10c4 > common/src/test/java/org/apache/falcon/util/HadoopQueueUtilTest.java > PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-1.json > PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-2.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/41916/diff/ > > > Testing > ------- > > Unit tests > Manual end to end tests > Secure cluster test > > > Thanks, > > Venkatesan Ramachandran > >
