-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17525/#review33201
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/17525/#comment62558>

    Can this switch be called effectiveTime instead



prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
<https://reviews.apache.org/r/17525/#comment62559>

    REST query param can also be called effectiveTime



webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java
<https://reviews.apache.org/r/17525/#comment62560>

    time to effectiveTime



webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java
<https://reviews.apache.org/r/17525/#comment62561>

    Looks like this function isn't being used. Dont know what is the impact of 
changing the end time to the first hour of the day to the first day of the 
month.


- Srikanth Sundarrajan


On Jan. 30, 2014, 5:48 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17525/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 5:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-264
>     https://issues.apache.org/jira/browse/FALCON-264
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Update with effective time in CLI
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f 
>   
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
>  025e1b7 
>   
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
>  7c3a425 
>   pom.xml 9252d80 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 
> 7333110 
>   
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
>  bbb1120 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 
> 86e0431 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 
> 1ceaabf 
> 
> Diff: https://reviews.apache.org/r/17525/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>

Reply via email to