> On Jan. 30, 2014, 6 a.m., Srikanth Sundarrajan wrote: > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 80 > > <https://reviews.apache.org/r/17525/diff/1/?file=454208#file454208line80> > > > > Can this switch be called effectiveTime instead
Its too long to write in CLI. So, used time instead > On Jan. 30, 2014, 6 a.m., Srikanth Sundarrajan wrote: > > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java, > > line 191 > > <https://reviews.apache.org/r/17525/diff/1/?file=454214#file454214line191> > > > > REST query param can also be called effectiveTime Yes, I can change this to effectiveTime > On Jan. 30, 2014, 6 a.m., Srikanth Sundarrajan wrote: > > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java, > > line 758 > > <https://reviews.apache.org/r/17525/diff/1/?file=454216#file454216line758> > > > > Looks like this function isn't being used. Dont know what is the impact > > of changing the end time to the first hour of the day to the first day of > > the month. I had a testcase that was using this. Let me check where it went missing. The example process used has frequency of 1 day. It doesn't set the time to first day of month, it adds one day so that effective time is in the future. - shwethags ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17525/#review33201 ----------------------------------------------------------- On Jan. 30, 2014, 5:48 a.m., Srikanth Sundarrajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17525/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 5:48 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-264 > https://issues.apache.org/jira/browse/FALCON-264 > > > Repository: falcon-git > > > Description > ------- > > Update with effective time in CLI > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e > client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f > > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java > 025e1b7 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 7c3a425 > pom.xml 9252d80 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > 7333110 > > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java > bbb1120 > webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java > 86e0431 > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > 1ceaabf > > Diff: https://reviews.apache.org/r/17525/diff/ > > > Testing > ------- > > > Thanks, > > Srikanth Sundarrajan > >
