[
https://issues.apache.org/jira/browse/FALCON-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107720#comment-14107720
]
Balu Vellanki commented on FALCON-166:
--------------------------------------
1. I removed that code. It was not necessary.
2 to 5 : I changed the code as suggested and made the numbers constants.
Frequency can never be null for entities, but my IDE showed a warning sign
because it can't verify that Frequency can never be null.
6. We need to compute across all clusters because, OozieWorkflowEngine action
call is done across all clusters. We cant exclude individual clusters here.
" how will Oozie work when a particular cluster does not start at this computed
start but somewhere later?" -- My understanding is that Oozie handles this
gracefully internally, but I will verify this assumption. If this assumption
holds false, it will be a separate Jira ticket.
> Instance status start and end dates are rigid and inconvenient
> --------------------------------------------------------------
>
> Key: FALCON-166
> URL: https://issues.apache.org/jira/browse/FALCON-166
> Project: Falcon
> Issue Type: Sub-task
> Components: webapp
> Affects Versions: 0.3
> Reporter: Venkatesh Seetharam
> Assignee: Balu Vellanki
> Fix For: 0.6
>
> Attachments: Falcon-Jira-166.patch
>
>
> There are 2 annoying issues that was brought up by [~srimanth.gunturi] while
> working on FALCON-164. The use case is to get the status for a given entity
> for the past 1 or 2 or 3 or 7 days.
> 1. Instance status with out an end date fetches for a very small window
> Instance status take end date as optional but assumes one second from the
> start date which is too small a window.
> {code}
> private Date getEndDate(Date start, String endStr) throws FalconException
> {
> Date end;
> if (StringUtils.isEmpty(endStr)) {
> end = new Date(start.getTime() + 1000); // next sec
> } else {
> end = EntityUtil.parseDateUTC(endStr);
> }
> return end;
> }
> {code}
> May be assuming the current time might be appropriate instead.
> 2. The start date has to be on or after the start of the entity.
> If the user has created the entity 2 days back but specified the start date
> for looking at the instances in the past 7 days, it should fetch what is
> valid rather than complain that the start date is before the entity's start.
> This is quite unwieldy to work with in a dashboard use case. I'm not sure
> what the performance impact is for this API to be changed.
> Thoughts?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
