[
https://issues.apache.org/jira/browse/FALCON-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110887#comment-14110887
]
Srikanth Sundarrajan commented on FALCON-166:
---------------------------------------------
My suggestion would be to make both start & end dates optional and add an
additional switch to provides the max instances for throttling responses.
Default value for start Time if missing should be based on endTime and
frequency of the feed/process simply (1 hour if the frequency is in minutes, 1
day if the frequency is in hours, 10 days if frequency is day and 1 month for
other day frequencies and 1 year otherwise.
Default value for endTime should be the current Time
Default value for maxInstances should be 30. (this value should be capped at
100/200 regardless what the user expects)
With these defaults it would be possible for folks to get basic instance status
without worrying about process or feed frequency or other properties. These
should also allow for clean support for pagination without worry about data
eviction in the underlying state db (of old instances).
> Instance status start and end dates are rigid and inconvenient
> --------------------------------------------------------------
>
> Key: FALCON-166
> URL: https://issues.apache.org/jira/browse/FALCON-166
> Project: Falcon
> Issue Type: Sub-task
> Components: webapp
> Affects Versions: 0.3
> Reporter: Venkatesh Seetharam
> Assignee: Balu Vellanki
> Fix For: 0.6
>
> Attachments: Falcon-Jira-166-v1.patch, Falcon-Jira-166-v2.patch,
> Falcon-Jira-166-v3.patch, Falcon-Jira-166.patch
>
>
> There are 2 annoying issues that was brought up by [~srimanth.gunturi] while
> working on FALCON-164. The use case is to get the status for a given entity
> for the past 1 or 2 or 3 or 7 days.
> 1. Instance status with out an end date fetches for a very small window
> Instance status take end date as optional but assumes one second from the
> start date which is too small a window.
> {code}
> private Date getEndDate(Date start, String endStr) throws FalconException
> {
> Date end;
> if (StringUtils.isEmpty(endStr)) {
> end = new Date(start.getTime() + 1000); // next sec
> } else {
> end = EntityUtil.parseDateUTC(endStr);
> }
> return end;
> }
> {code}
> May be assuming the current time might be appropriate instead.
> 2. The start date has to be on or after the start of the entity.
> If the user has created the entity 2 days back but specified the start date
> for looking at the instances in the past 7 days, it should fetch what is
> valid rather than complain that the start date is before the entity's start.
> This is quite unwieldy to work with in a dashboard use case. I'm not sure
> what the performance impact is for this API to be changed.
> Thoughts?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
