----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27280/#review59247 -----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java <https://reviews.apache.org/r/27280/#comment100517> Are we expecting widespread usage of these methods ? If not can we make it local to the test. falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java <https://reviews.apache.org/r/27280/#comment100516> Are we assuming that the tests are being run as oozie ? falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java <https://reviews.apache.org/r/27280/#comment100519> Can we use createMissingDependenciesForBundle() method here ? To me it seems that they are doing similar things. Is a unification possible ? falcon-regression/merlin/src/test/java/org/apache/falcon/regression/RetryTest.java <https://reviews.apache.org/r/27280/#comment100523> mass import ? falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java <https://reviews.apache.org/r/27280/#comment100520> I thing line exceeds 100 char limit ? - Raghav Gautam On Oct. 30, 2014, 5:46 a.m., samarth gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27280/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 5:46 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > https://issues.apache.org/jira/browse/FALCON-618 > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java > 02f572e > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java > 5ee6dd2 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java > dab5d2c > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java > 024a652 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java > 73cf8c8 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java > 86d4d47 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java > c6217c1 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java > d4f31e9 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java > f564bb4 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java > a94cf1a > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java > 3f7258e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/RetryTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java > 991732b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java > 9b5d770 > > falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/process-agg.xml > 03cb727 > > Diff: https://reviews.apache.org/r/27280/diff/ > > > Testing > ------- > > > Thanks, > > samarth gupta > >
