> On Oct. 30, 2014, 8:50 p.m., Raghav Gautam wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java, > > line 493 > > <https://reviews.apache.org/r/27280/diff/2/?file=742868#file742868line493> > > > > Are we expecting widespread usage of these methods ? If not can we make > > it local to the test.
yes , i expect widespred use of the method in future, particularly with introduction of ACL in cluster and process also. We can move to local test for now, but problem with that is many times we forget abt it and result in rewriting the same helper methods. > On Oct. 30, 2014, 8:50 p.m., Raghav Gautam wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java, > > line 499 > > <https://reviews.apache.org/r/27280/diff/2/?file=742868#file742868line499> > > > > Are we assuming that the tests are being run as oozie ? no we are not. We are just trying to send request as OOZIE user. What i am trying to achive is since we need to change / create path permission , it should be done as one of the users who is authorized to proxy on behalf of hdfs ( on a secutiry enabled hdfs where we dont have "chmod 777 /" ) . only assumtion is that since our regression setup requires oozie running , user who started oozie must be present as proxy in hdfs conf. > On Oct. 30, 2014, 8:50 p.m., Raghav Gautam wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java, > > line 496 > > <https://reviews.apache.org/r/27280/diff/2/?file=742871#file742871line496> > > > > Can we use createMissingDependenciesForBundle() method here ? To me it > > seems that they are doing similar things. Is a unification possible ? i tried that initially. But problem i faced was, different namenode for hdfs and conf object. For replication coord is created on target but the missing dependency is of source cluster which is having different end point of "fs.default.name" . So hdfs client was giving error while trying to create it. Will have a relook at it. - samarth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27280/#review59247 ----------------------------------------------------------- On Oct. 30, 2014, 12:46 p.m., samarth gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27280/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 12:46 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > https://issues.apache.org/jira/browse/FALCON-618 > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java > 02f572e > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java > 5ee6dd2 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java > dab5d2c > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java > 024a652 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java > 73cf8c8 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java > 86d4d47 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java > c6217c1 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java > d4f31e9 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java > f564bb4 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java > a94cf1a > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java > 3f7258e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/RetryTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java > 991732b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java > 9b5d770 > > falcon-regression/merlin/src/test/resources/RetryTests/valid1/bundle1/process-agg.xml > 03cb727 > > Diff: https://reviews.apache.org/r/27280/diff/ > > > Testing > ------- > > > Thanks, > > samarth gupta > >
