> On Jan. 2, 2015, 4:31 a.m., Srikanth Sundarrajan wrote: > > common/src/main/java/org/apache/falcon/entity/EntityUtil.java, line 68 > > <https://reviews.apache.org/r/29522/diff/1/?file=805099#file805099line68> > > > > This being static isn't thread safe
Above change is reverted as availabilityFlag is now set in Hadoop job conf. > On Jan. 2, 2015, 4:31 a.m., Srikanth Sundarrajan wrote: > > replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java, > > line 171 > > <https://reviews.apache.org/r/29522/diff/1/?file=805105#file805105line171> > > > > Write availability flag to a hadoop job conf and retrieve it from the > > conf instead of mutating the SUCCEEDED_FILE_NAME in EntityUtil This issue has been fixed by setting availabilityFlag to a Hadoop job conf. - Peeyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29522/#review66508 ----------------------------------------------------------- On Jan. 1, 2015, 7:26 a.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29522/ > ----------------------------------------------------------- > > (Updated Jan. 1, 2015, 7:26 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-237 > https://issues.apache.org/jira/browse/FALCON-237 > > > Repository: falcon-git > > > Description > ------- > > falcon feed replication should honour availability flag > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/EntityUtil.java 1a5d30c > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationCoordinatorBuilder.java > 2963ac9 > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java > cbe055a > > oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java > 75faceb > oozie/src/main/resources/action/feed/replication-action.xml da40b74 > > oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java > e5588b4 > replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java > 90ac753 > > replication/src/main/java/org/apache/falcon/replication/FilteredCopyListing.java > 58c09b4 > > Diff: https://reviews.apache.org/r/29522/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Peeyush Bishnoi > >
