> On Jan. 6, 2015, 12:20 p.m., shaik idris wrote: > > replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java, > > line 78 > > <https://reviews.apache.org/r/29522/diff/3/?file=807677#file807677line78> > > > > Minor, can you prefix the property name with falcon. > > falcon.feed.availability.flag
Fixed. > On Jan. 6, 2015, 12:20 p.m., shaik idris wrote: > > replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java, > > line 172 > > <https://reviews.apache.org/r/29522/diff/3/?file=807677#file807677line172> > > > > Since it is used multiple times as String, make sense to extract > > feed.availability.flag as constant. Fixed. - Peeyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29522/#review66820 ----------------------------------------------------------- On Jan. 6, 2015, 10:50 a.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29522/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 10:50 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-237 > https://issues.apache.org/jira/browse/FALCON-237 > > > Repository: falcon-git > > > Description > ------- > > falcon feed replication should honour availability flag > > > Diffs > ----- > > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationCoordinatorBuilder.java > 2963ac9 > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java > cbe055a > > oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java > 75faceb > oozie/src/main/resources/action/feed/replication-action.xml da40b74 > > oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java > e5588b4 > replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java > 90ac753 > > replication/src/main/java/org/apache/falcon/replication/FilteredCopyListing.java > 58c09b4 > > Diff: https://reviews.apache.org/r/29522/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Peeyush Bishnoi > >
