[ 
https://issues.apache.org/jira/browse/FELIX-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521820
 ] 

Stuart McCulloch commented on FELIX-343:
----------------------------------------

well, we can always add an info message to let people know what's happening 
(like it does at the moment wrt. overriding)

how about:

   <Include-MavenResources>true</Include-MavenResources>

with true as the default (when false then maven resources are not included)

one concern I have with the name is that we might want to stress it's a flag, 
not a list like Include-Resource - other choices are:

   <Add-MavenResources>true</Add-MavenResources>

   <Combine-MavenResources>true</Combine-MavenResources>

   <Maven-Resources>true</Maven-Resources>

WDYT?  any better names for the flag / opinions on the default :)



> Add "additional-Resource" option
> --------------------------------
>
>                 Key: FELIX-343
>                 URL: https://issues.apache.org/jira/browse/FELIX-343
>             Project: Felix
>          Issue Type: Improvement
>          Components: Maven Bundle Plugin
>    Affects Versions: 1.0.0
>            Reporter: Carsten Ziegeler
>         Attachments: patch.txt
>
>
> The "Include-Resource" option is currently a all-or-nothing option which is 
> directly forwarded to bnd. One can either use the default (the maven resource 
> paths) or specify the whole paths oneself. In many cases it is more desirable 
> to just provide additional paths to the default maven paths.
> Therefore I created a patch which adds an "addtional-Resource" property. The 
> logic is as follows:
> - If Include-Resource is specified but no additional-Resource: 
> Include-Resource is forwarded to bnd
> - If Include-Resource is specified and additional-Resource: 
> Include-Resource+','+additionalResource is forwarded to bnd
> - if no Include-Resource is specified and no additional-Resource: maven 
> resource paths are forwarded to bnd
> - if no Include-Resource is specified and additional-Resource is given: maven 
> resource paths + additionalResource are forwarded to bnd.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to