[
https://issues.apache.org/jira/browse/FELIX-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665510#action_12665510
]
Richard S. Hall commented on FELIX-884:
---------------------------------------
I think the combined patch looks pretty good. I have the following suggestions
(some of which are a result of the patch and other which are pre-existing but
related to the patch):
Make RepositoryAdminImpl.m_local, ResolverImpl.m_context, ResolverImpl.m_admin,
and LocalRepositoryImpl.m_context final so we don't have to worry about
concurrent visibility.
Make LocalRepositoryImpl.bundleChanged(), LocalRepositoryImpl.serviceChanged(),
and LocalRepositoryImpl.initialize() (or LocalRepositoryImpl.addBundle())
synchronized since they are accessing shared state.
Fix formating of LocalRepositoryImpl.removeBundle() method.
There are actually some other changes I will look into too, but these seem to
be the most relevant to the proposed patch. If you agree, then I think the
patch is ready with these changes. If not, then let's discuss it.
> OBR should expose registered services as capabilities of local repository
> -------------------------------------------------------------------------
>
> Key: FELIX-884
> URL: https://issues.apache.org/jira/browse/FELIX-884
> Project: Felix
> Issue Type: Improvement
> Components: Bundle Repository (OBR)
> Affects Versions: bundlerepository-1.2.0
> Reporter: Felix Meschberger
> Attachments: FELIX-884-2.patch, FELIX-884-3.patch, FELIX-884.patch
>
>
> The OBR implementation exposes the current state of the framework as a
> Repository, the LocalRepository. This provides the installed bundles as parts
> provided by a repository with their capabilities. These capabilities do not
> currently only reflect the currently installed set of bundles and their
> static setup such as package import/export and service import/export. The
> actually registered services, though are not exposed as capabilities
> whatsoever.
> So if for example, the OPS4J Pax Web Service bundle registers an HttpService
> instance. But this fact is not reflected by a ExportService header. Trying to
> install a bundle from the OBR which requires an HttpService fails, since the
> actually registered HttpService is not provided as a capability.
> I suggest, the LocalRepository exposes all registered services (just their
> names would probably do it) as capabilities of the system bundle. This is not
> entirely correct but should probably be enough to satisfy the requirements of
> bundles.
> WDYT ?
> Ref: Discussion on user list at http://markmail.org/message/ivkdvhpk4gclkylv
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
