[
https://issues.apache.org/jira/browse/FELIX-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665543#action_12665543
]
Felix Meschberger commented on FELIX-884:
-----------------------------------------
> Make RepositoryAdminImpl.m_local, ResolverImpl.m_context,
> ResolverImpl.m_admin, and LocalRepositoryImpl.m_context final
Sure, done.
> Make LocalRepositoryImpl.bundleChanged(),
> LocalRepositoryImpl.serviceChanged(), and LocalRepositoryImpl.initialize()
For bundleChanged and serviceChanged I synchronized the blocks actually
changing state, such that synchronization is only done if the event type causes
internal state change. In the initialize() method I synchronized on the call to
BundleContext.getBundles() plus the internal addition of the bundles plus the
assignement of the snapshot timestamp.
In addition I added comments to addBundle and removeBundle, that they must be
called synchronized on the instance.
> Fix formatting
Done, escaped my format control
> OBR should expose registered services as capabilities of local repository
> -------------------------------------------------------------------------
>
> Key: FELIX-884
> URL: https://issues.apache.org/jira/browse/FELIX-884
> Project: Felix
> Issue Type: Improvement
> Components: Bundle Repository (OBR)
> Affects Versions: bundlerepository-1.2.0
> Reporter: Felix Meschberger
> Attachments: FELIX-884-2.patch, FELIX-884-3.patch, FELIX-884.patch
>
>
> The OBR implementation exposes the current state of the framework as a
> Repository, the LocalRepository. This provides the installed bundles as parts
> provided by a repository with their capabilities. These capabilities do not
> currently only reflect the currently installed set of bundles and their
> static setup such as package import/export and service import/export. The
> actually registered services, though are not exposed as capabilities
> whatsoever.
> So if for example, the OPS4J Pax Web Service bundle registers an HttpService
> instance. But this fact is not reflected by a ExportService header. Trying to
> install a bundle from the OBR which requires an HttpService fails, since the
> actually registered HttpService is not provided as a capability.
> I suggest, the LocalRepository exposes all registered services (just their
> names would probably do it) as capabilities of the system bundle. This is not
> entirely correct but should probably be enough to satisfy the requirements of
> bundles.
> WDYT ?
> Ref: Discussion on user list at http://markmail.org/message/ivkdvhpk4gclkylv
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
