Hi, Richard S. Hall schrieb: > I am willing to patch it. I am not too concerned with the backwards > compatibility issue, since it is easy to resolve. > > If no one objects, I will patch it next week. However, in my mind I > consider Felix the owner of this, so I would rather have him do it. :-D
Done. Will also update the doc page. Regards Felix > > -> richard > > Sahoo wrote: >> Is anyone going to apply this patch? >> >> Thanks, >> Sahoo >> >> Peter wrote: >>> Hi all, >>> >>> In my personal opinion, although backward compatibility is important >>> in this case I would do it for two main reasons: >>> 1) In most cases this will be the desired behaviour. >>> 2) In the cases where it is not, it still does not break the >>> application, but only the administration of the application, so the >>> impact of the change is not very big. Also the change is pretty easy >>> to detect and if this is documented on the webpage very fast to correct. >>> >>> >>> >>> Regards >>> >>> Peter >>> >>> Felix Meschberger schrieb: >>>> Hi all, >>>> >>>> Thanks Peter for providing this patch. I think the proposed patch is >>>> perfectly valid and good idea to start with. >>>> >>>> My worries are with existing setups: in a backwards compatibility >>>> scenario, I would bind to 0.0.0.0 by default instead of just localhost. >>>> In a security-by-default scenario I would agree with Peter, that >>>> remote.shell should bind to localhost only. >>>> >>>> Any opinions on what scenario -- compatible binding 0.0.0.0 or security >>>> binding 127.0.0.1 -- going forward ? >>>> >>>> Regards and Thanks >>>> Felix >>>> >>>> >>>> >>>> >>>> Peter Triller (JIRA) schrieb: >>>> >>>>> Enable the remote shell to bind to an IP and make 127.0.0.1 the >>>>> default >>>>> ----------------------------------------------------------------------- >>>>> >>>>> >>>>> Key: FELIX-826 >>>>> URL: https://issues.apache.org/jira/browse/FELIX-826 >>>>> Project: Felix >>>>> Issue Type: New Feature >>>>> Components: Remote Shell >>>>> Affects Versions: shell.remote-1.0.2 >>>>> Reporter: Peter Triller >>>>> >>>>> >>>>> >>>>> >>>>> >>> >
