[ 
https://issues.apache.org/jira/browse/FELIX-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744109#action_12744109
 ] 

Guillaume Nodet commented on FELIX-1066:
----------------------------------------

I have a problem with this patch.  It means if someone has an xml repository 
deployed with no maven classifier, it won't work.
    mvn:foo/bar/1.0/xml

then this patch will automatically add /features to the uri.
I think it would be better to try loading the file using the plain url, and 
maybe try again with /xml/features or /features appended to the uri.
Or maybe it was a bad idea ...

> Assume a default type/classified (xml/features) on the features 
> addUrl/removeUrl commands
> -----------------------------------------------------------------------------------------
>
>                 Key: FELIX-1066
>                 URL: https://issues.apache.org/jira/browse/FELIX-1066
>             Project: Felix
>          Issue Type: Improvement
>          Components: Karaf
>            Reporter: Guillaume Nodet
>         Attachments: FELIX-1066-OptionalMavenUrlComponents.patch
>
>
> When doing an features/addUrl, you always have to specify the type (xml) and 
> classifier (features). How about making that the default, so people can just 
> do:
> {code}
> features/addUrl mvn:org.apache.servicemix.features/apache-servicemix/4.0.0
> {code}
> We can always fail-back to type jar if we don't find the xml file to support 
> deploying new feature descriptors through a bundle.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to