[ 
https://issues.apache.org/jira/browse/FELIX-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744112#action_12744112
 ] 

Tim Moloney commented on FELIX-1066:
------------------------------------

True.  In fact, that's how my features repo was deployed before this patch, but 
I thought that I wasn't following convention, so I changed it.

I'm leaning towards "bad idea" personally.

I've been running with the patch for the last couple of days and I've found the 
following:
- loading the URI when it is missing the version is slower than just typing the 
version
  (note that defaulting the version wasn't part of the original issue)
- it forces people to use the "features" classifier
- if we attempt to load the file without the features modifier, then on 
failure, attempt with
  the features modifier, I believe it will be as slow as omitting the version 
(I haven't
  tested this so I could be wrong)

Overall, it seems to add too much overhead to save a few keystrokes.


> Assume a default type/classified (xml/features) on the features 
> addUrl/removeUrl commands
> -----------------------------------------------------------------------------------------
>
>                 Key: FELIX-1066
>                 URL: https://issues.apache.org/jira/browse/FELIX-1066
>             Project: Felix
>          Issue Type: Improvement
>          Components: Karaf
>            Reporter: Guillaume Nodet
>         Attachments: FELIX-1066-OptionalMavenUrlComponents.patch
>
>
> When doing an features/addUrl, you always have to specify the type (xml) and 
> classifier (features). How about making that the default, so people can just 
> do:
> {code}
> features/addUrl mvn:org.apache.servicemix.features/apache-servicemix/4.0.0
> {code}
> We can always fail-back to type jar if we don't find the xml file to support 
> deploying new feature descriptors through a bundle.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to